Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: translate the region select box #321

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Conversation

seriouszyx
Copy link
Contributor

@seriouszyx seriouszyx commented Nov 10, 2021

Fix: #320

I used i18n-iso-countries. The results are shown below.

image

image

image

image

image

image

image

And our CDN lacks the UM icon, plz add it. The country-flag-icons has been provided.

image

image

Signed-off-by: “seriouszyx” seriouszyx@foxmail.com

@casbin-bot
Copy link
Contributor

@tangyang9464 please review

@hsluoyz
Copy link
Member

hsluoyz commented Nov 10, 2021

@hyperzlib plz review

Copy link
Member

@hsluoyz hsluoyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is really smart! I didn't see so smart PRs in months!

web/yarn.lock Outdated Show resolved Hide resolved
web/yarn.lock Outdated Show resolved Hide resolved
Signed-off-by: “seriouszyx” <seriouszyx@foxmail.com>
@hsluoyz hsluoyz merged commit f5fdf0a into casdoor:master Nov 10, 2021
@casbin-bot
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate the region select box
3 participants