Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong sub return and docker-compose boolean value error. #375

Merged
merged 2 commits into from
Dec 16, 2021
Merged

fix: wrong sub return and docker-compose boolean value error. #375

merged 2 commits into from
Dec 16, 2021

Conversation

Steve0x2a
Copy link
Member

  1. in get-account api, sub should reruen user's id instead of user's name.
  2. according to this document, any boolean values (true, false, yes, no) need to be enclosed in quotes to ensure they are not converted to True or False by the YML parser.

@Steve0x2a
fix: wrong sub return
6ad873d 
Signed-off-by: 0x2a <stevesough@gmail.com>
@Steve0x2a
fix: yaml bool value must be enclosed in quotes
4e1e618 
Signed-off-by: 0x2a <stevesough@gmail.com>
@casbin-bot
Copy link
Contributor

@seriouszyx @tangyang9464 please review

@hsluoyz
Copy link
Member

hsluoyz commented Dec 16, 2021

lgtm

@hsluoyz hsluoyz merged commit 2f70e77 into casdoor:master Dec 16, 2021
@casbin-bot
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Steve0x2a Steve0x2a deleted the fix/sub branch March 4, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seriouszyx seriouszyx Awaiting requested review from seriouszyx

@tangyang9464 tangyang9464 Awaiting requested review from tangyang9464

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Steve0x2a @casbin-bot @hsluoyz