-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the built-in BatchFileAdapter class back to FileAdapter #235
Labels
bug
Something isn't working
Comments
hsluoyz
added this to Node-Casbin Easy Tasks
in Casbin Easy Tasks for Beginners/Student Applicants
Feb 6, 2021
So we should move the batch functions and update function to FileAdapter? |
@Zxilly see Go code. |
hsluoyz
removed this from Node-Casbin Easy Tasks
in Casbin Easy Tasks for Beginners/Student Applicants
Feb 6, 2021
hsluoyz
pushed a commit
that referenced
this issue
Feb 6, 2021
* feat: add updatePolicy() Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * feat: add unittest for updatePolicy() Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * feat: add updateForUpdatePolicy() Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * feat: add updatePolicy() Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * refactor: rename interface Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * docs: fix comment Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * fix: fix adapter error Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * feat: add updatableFileAdapter Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * fix: remove incorrect claim and fix comment Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * fix: fix comment Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * perf: refactor updatePolicy Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * fix: fix index Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * style: prevent conflict Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * fix: remove UpdatableFileAdapter Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * fix: fix unittest() In fact,this makes unittest cannot pass.The fix will refer to issue #235 Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See my comments here: #234 (comment)
I think first we need correctify the BatchFileAdapter code: rename BatchFileAdapter back to FileAdapter. From now on, FileAdapter will always be called FileAdapter, no matter how many interfaces it has implemented.
node-casbin/src/persist/batchFileAdapter.ts
Lines 8 to 28 in 27005f8
The text was updated successfully, but these errors were encountered: