Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transfer from micromatch to picomatch #264

Merged
merged 2 commits into from
May 2, 2021
Merged

fix: transfer from micromatch to picomatch #264

merged 2 commits into from
May 2, 2021

Conversation

Zxilly
Copy link
Contributor

@Zxilly Zxilly commented May 2, 2021

ref to discussion at #257 (comment)

This will remove dependency on node/util

Signed-off-by: Zxilly zhouxinyu1001@gmail.com

@Zxilly Zxilly requested review from hsluoyz, nodece and ebreak May 2, 2021 04:37
@coveralls
Copy link

coveralls commented May 2, 2021

Pull Request Test Coverage Report for Build 803594762

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 76.961%

Totals Coverage Status
Change from base Build 802243626: -0.009%
Covered Lines: 1244
Relevant Lines: 1554

💛 - Coveralls

@coveralls
Copy link

coveralls commented May 2, 2021

Pull Request Test Coverage Report for Build 804258976

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 76.961%

Totals Coverage Status
Change from base Build 803718006: -0.009%
Covered Lines: 1244
Relevant Lines: 1554

💛 - Coveralls

@casbin casbin deleted a comment from coveralls May 2, 2021
yarn.lock Outdated Show resolved Hide resolved
@hsluoyz
Copy link
Member

hsluoyz commented May 2, 2021

@Zxilly plz resolve conflicts:

image

@Zxilly
Copy link
Contributor Author

Zxilly commented May 2, 2021

@hsluoyz resolved

@Zxilly Zxilly requested a review from hsluoyz May 2, 2021 06:24
Copy link
Member

@hsluoyz hsluoyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn.lock is not updated

@nodece
Copy link
Member

nodece commented May 2, 2021

@Zxilly use fix instead refactor. If the commit does not contain breaking changes, use fix is enough.

Zxilly added 2 commits May 2, 2021 20:20
This will remove dependency on `node/utils`

Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
@Zxilly Zxilly requested a review from hsluoyz May 2, 2021 12:23
@Zxilly Zxilly changed the title refactor: transfer from micromatch to picomatch fix: transfer from micromatch to picomatch May 2, 2021
@hsluoyz hsluoyz merged commit 6be1b06 into casbin:master May 2, 2021
github-actions bot pushed a commit that referenced this pull request May 2, 2021
## [5.6.2](v5.6.1...v5.6.2) (2021-05-02)

### Bug Fixes

* transfer from micromatch to picomatch ([#264](#264)) ([6be1b06](6be1b06))
@github-actions
Copy link

github-actions bot commented May 2, 2021

🎉 This PR is included in version 5.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants