feat(rbac): implement getUsersForRoleInDomain & getRolesForUserInDomain
#351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Gabriel-403 @Zxilly @kingiw @nodece please review |
|
|
Documentation indicates that there is existance of `getUsersForRoleInDomain` and `getRolesForUserInDomain` api, but it does not yet exists. This commit implements these functions, by aliasing them to existing rbac function that had already cater for domain apis, to increase and improve dev experience. re casbin#304
|
🎉 This PR is included in version 5.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Zxilly
added a commit
that referenced
this pull request
Apr 15, 2022
* fix: *matcher result should be boolean or number* for KeyGet2 (#347) * fix: *matcher result should be boolean or number* for KeyGet2 * fix: updated error hint * fix: basic keyGet2 test * fix: basic_keyget2_policy.csv (cherry picked from commit 0257078) Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * feat(rbac): add `getUsersForRoleInDomain` & `getRolesForUserInDomain` (#351) Documentation indicates that there is existance of `getUsersForRoleInDomain` and `getRolesForUserInDomain` api, but it does not yet exists. This commit implements these functions, by aliasing them to existing rbac function that had already cater for domain apis, to increase and improve dev experience. re #304 (cherry picked from commit 4896ca2) * feat: #357 Support keyMatch5 (#359) (cherry picked from commit e6a6d8a) * test: use new utils Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> Co-authored-by: Shivansh Yadav <yadavshivansh@gmail.com> Co-authored-by: Chen Wen Kang <23054115+cwkang1998@users.noreply.github.com> Co-authored-by: ZCDC_Ren <kuanglong0312@sina.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation indicates that there is existance of
getUsersForRoleInDomainandgetRolesForUserInDomainapi, but it does not yet exists. This commit implements these functions,by aliasing them to existing rbac function that had already cater for domain apis, to increase and
improve dev experience.
Fix: #304