Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code review of project 2 and project 4 #1

Open
wq-yang opened this issue Nov 10, 2020 · 1 comment
Open

code review of project 2 and project 4 #1

wq-yang opened this issue Nov 10, 2020 · 1 comment

Comments

@wq-yang
Copy link
Collaborator

wq-yang commented Nov 10, 2020

Your project is really great, impressive.

It is well-designed and precisely implemented. You designed two components, and in the two components, you designed classes and methods. The structure is clear with modulars. And it works well, exactly achieves your MVP of extracting and analyzing Twitter trend sentiments.

Your code is clear with great readability, because your variable names are self-descriptive, and the code is well-commented.

You also have great error handling in your TWITTER STREAM LISTENER. It handles errors that may occur in printing data and writing data to fetched_tweets_filename.

You also have clear documentation with examples of extracting tweets and analyzing sentiments.

You also did unit test on possible errors users may meet with, which is great. You tested what will happen when Twitter credentials are wrong and also, when Google Cloud NLP service is down.

Your project will be even better if:

  1. Not putting your Twitter credentials on GitHub, because it may be abused if someone stole your credentials.
  2. Integrate your two components, to make it more easy to use for common users. Maybe user only need to input keyword and will get results (tweets extracted and their sentiment) automatically.
  3. I'm not sure if it's my problem, when I run TwitterAPI.ipynb on Google Colab, it prints huge amount of data, and it seems that it is running forever, making the page really slow. Maybe you can offer users an option to extract tweets of the latest several minutes, or limit the extracting speed, rather than lively extracting all tweets about the keyword
@CaseyZhang11
Copy link
Owner

Thank you for your comment. I will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants