[CLI] Add tabs command

RELEASING.md

@@ -44,6 +44,8 @@ $ rush build
 
 - Commit all code changes with a commit message starting with `[RELEASE] 0.1.3-4.`
 
+### Optional use of Rush Change for formatted changelog
+
 - Use `rush change` to update the Changelog. Commit and squash these changes into the `[RELEASE] X.Y.Z-Q` commit.
 
 - 🎉 Congratulations! You've released a new set of `@misk` packages! Downstream `misk-web` tabs can now simply update the `version` in their `miskTab.json` and on their next build, they will start using the latest packages.

common/config/rush/version-policies.json

@@ -12,7 +12,7 @@
   {
     "definitionName": "lockStepVersion",
     "policyName": "MiskWeb",
-    "version": "0.1.7",
+    "version": "0.1.8",
     "nextBump": "patch"
   }
   // {

examples/data/package.json

@@ -15,13 +15,13 @@
     "prepare": "npm run-script build"
   },
   "dependencies": {
-    "@misk/core": "0.1.7",
+    "@misk/core": "0.1.8",
     "fs-extra": "8.0.1"
   },
   "devDependencies": {
-    "@misk/dev": "0.1.7",
+    "@misk/dev": "0.1.8",
     "@types/fs-extra": "7.0.0",
-    "@misk/tslint": "0.1.7",
+    "@misk/tslint": "0.1.8",
     "@types/node": "11.13.1",
     "@types/prop-types": "15.7.1",
     "@types/react": "16.8.21",

examples/services/dashboard/miskTab.json

@@ -10,7 +10,7 @@
   "relative_path_prefix": "",
   "slug": "dashboard",
   "useWebpackExternals": true,
-  "version": "0.1.7",
+  "version": "0.1.8",
   "zipOnBuild": false,
   "___DeprecatedKeys": "Any keys below this point in your miskTab.json are deprecated and can be safely removed."
 }

examples/services/dashboard/package.json

@@ -19,9 +19,9 @@
     "zip": "tar --exclude='.gitignore' --exclude='.old_build_files' --exclude='package.json' --exclude='package-lock.json' --exclude='prettier.config.js' --exclude='tsconfig.json' --exclude='tslint.json' --exclude='webpack.config.js' --exclude='yarn.lock' --exclude='demo' --exclude='lib' --exclude='.DS_Store' --exclude='*.log' --exclude='node_modules' --exclude='dashboard.tgz' -czvf dashboard.tgz ./"
   },
   "dependencies": {
-    "@misk/common": "0.1.7",
-    "@misk/core": "0.1.7",
-    "@misk/simpleredux": "0.1.7",
+    "@misk/common": "0.1.8",
+    "@misk/core": "0.1.8",
+    "@misk/simpleredux": "0.1.8",
     "@blueprintjs/core": "3.16.0",
     "@blueprintjs/datetime": "3.10.0",
     "@blueprintjs/icons": "3.9.0",
@@ -52,9 +52,9 @@
     "styled-components": "4.3.2"
   },
   "devDependencies": {
-    "@misk/dev": "0.1.7",
-    "@misk/test": "0.1.7",
-    "@misk/tslint": "0.1.7",
+    "@misk/dev": "0.1.8",
+    "@misk/test": "0.1.8",
+    "@misk/tslint": "0.1.8",
     "@types/history": "4.7.2",
     "@types/jest": "24.0.15",
     "@types/node": "11.13.1",

examples/tabs/palette-exemplar/miskTab.json

@@ -10,7 +10,7 @@
   "relative_path_prefix": "",
   "slug": "palette-exemplar",
   "useWebpackExternals": true,
-  "version": "0.1.7",
+  "version": "0.1.8",
   "zipOnBuild": true,
   "___DeprecatedKeys": "Any keys below this point in your miskTab.json are deprecated and can be safely removed."
 }

examples/tabs/palette-exemplar/package.json

@@ -19,9 +19,9 @@
     "zip": "tar --exclude='.gitignore' --exclude='.old_build_files' --exclude='package.json' --exclude='package-lock.json' --exclude='prettier.config.js' --exclude='tsconfig.json' --exclude='tslint.json' --exclude='webpack.config.js' --exclude='yarn.lock' --exclude='demo' --exclude='lib' --exclude='.DS_Store' --exclude='*.log' --exclude='node_modules' --exclude='palette-exemplar.tgz' -czvf palette-exemplar.tgz ./"
   },
   "dependencies": {
-    "@misk/common": "0.1.6",
-    "@misk/core": "0.1.6",
-    "@misk/simpleredux": "0.1.6",
+    "@misk/common": "0.1.7",
+    "@misk/core": "0.1.7",
+    "@misk/simpleredux": "0.1.7",
     "@blueprintjs/core": "3.16.0",
     "@blueprintjs/datetime": "3.10.0",
     "@blueprintjs/icons": "3.9.0",
@@ -52,10 +52,10 @@
     "styled-components": "4.3.2"
   },
   "devDependencies": {
-    "@misk/dev": "0.1.6",
-    "@misk/test": "0.1.6",
+    "@misk/dev": "0.1.7",
+    "@misk/test": "0.1.7",
     "jest-emotion": "10.0.11",
-    "@misk/tslint": "0.1.6",
+    "@misk/tslint": "0.1.7",
     "@types/history": "4.7.2",
     "@types/jest": "24.0.15",
     "@types/node": "11.13.1",

examples/tabs/palette/miskTab.json

@@ -10,7 +10,7 @@
   "relative_path_prefix": "_admin/",
   "slug": "palette",
   "useWebpackExternals": true,
-  "version": "0.1.7",
+  "version": "0.1.8",
   "zipOnBuild": true,
   "___DeprecatedKeys": "Any keys below this point in your miskTab.json are deprecated and can be safely removed."
 }

examples/tabs/palette/package.json

@@ -19,9 +19,9 @@
     "zip": "tar --exclude='.gitignore' --exclude='.old_build_files' --exclude='package.json' --exclude='package-lock.json' --exclude='prettier.config.js' --exclude='tsconfig.json' --exclude='tslint.json' --exclude='webpack.config.js' --exclude='yarn.lock' --exclude='demo' --exclude='lib' --exclude='.DS_Store' --exclude='*.log' --exclude='node_modules' --exclude='palette.tgz' -czvf palette.tgz ./"
   },
   "dependencies": {
-    "@misk/common": "0.1.7",
-    "@misk/core": "0.1.7",
-    "@misk/simpleredux": "0.1.7",
+    "@misk/common": "0.1.8",
+    "@misk/core": "0.1.8",
+    "@misk/simpleredux": "0.1.8",
     "@blueprintjs/core": "3.16.0",
     "@blueprintjs/datetime": "3.10.0",
     "@blueprintjs/icons": "3.9.0",
@@ -52,9 +52,9 @@
     "styled-components": "4.3.2"
   },
   "devDependencies": {
-    "@misk/dev": "0.1.7",
-    "@misk/test": "0.1.7",
-    "@misk/tslint": "0.1.7",
+    "@misk/dev": "0.1.8",
+    "@misk/test": "0.1.8",
+    "@misk/tslint": "0.1.8",
     "@types/history": "4.7.2",
     "@types/jest": "24.0.15",
     "@types/node": "11.13.1",

packages/@misk/cli/CHANGELOG.json

@@ -1,6 +1,12 @@
 {
   "name": "@misk/cli",
   "entries": [
+    {
+      "version": "0.1.8",
+      "tag": "@misk/cli_v0.1.8",
+      "date": "Thu, 11 Jul 2019 17:39:26 GMT",
+      "comments": {}
+    },
     {
       "version": "0.1.7",
       "tag": "@misk/cli_v0.1.7",

packages/@misk/cli/CHANGELOG.md

@@ -1,6 +1,11 @@
 # Change Log - @misk/cli
 
-This log was last generated on Fri, 28 Jun 2019 14:39:38 GMT and should not be manually modified.
+This log was last generated on Thu, 11 Jul 2019 17:39:26 GMT and should not be manually modified.
+
+## 0.1.8
+Thu, 11 Jul 2019 17:39:26 GMT
+
+*Version update only*
 
 ## 0.1.7
 Fri, 28 Jun 2019 14:39:38 GMT

packages/@misk/cli/README.md

@@ -46,10 +46,11 @@ Commands:
 
   miskweb start                start Webpack Dev Server for live editing
 
-  miskweb test-coverage        generate test coverage report with `jest --
-                               --coverage`
+  miskweb tabs                 prints path of all downstream tabs
 
-  miskweb test-update          update test snapshots with `jest -- -u`
+  miskweb test-coverage        generate test coverage report
+
+  miskweb test-update          update test snapshots
 
   miskweb test                 run tests
 

packages/@misk/cli/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@misk/cli",
-  "version": "0.1.7",
+  "version": "0.1.8",
   "license": "SEE LICENSE IN https://github.com/cashapp/misk-web",
   "description": "Misk-Web CLI Build Tool",
   "author": "CashApp/Misk-Web Authors (https://github.com/cashapp/misk-web/graphs/contributors)",
@@ -31,7 +31,7 @@
     "test": "jest --passWithNoTests"
   },
   "dependencies": {
-    "@misk/test": "0.1.7",
+    "@misk/test": "0.1.8",
     "axios": "0.19.0",
     "dayjs": "1.8.14",
     "fs-extra": "8.0.1",
@@ -47,14 +47,14 @@
     "yargs": "13.2.4"
   },
   "devDependencies": {
-    "@misk/dev": "0.1.7",
+    "@misk/dev": "0.1.8",
     "@types/jest": "24.0.15",
     "jest": "24.8.0",
     "jest-emotion": "10.0.11",
     "jest-serializer-html": "7.0.0",
     "react-testing-library": "6.1.2",
     "ts-jest": "24.0.2",
-    "@misk/tslint": "0.1.7",
+    "@misk/tslint": "0.1.8",
     "@types/fs-extra": "7.0.0",
     "@types/klaw": "3.0.0",
     "@types/lodash": "4.14.134",

packages/@misk/cli/src/commands/tabs.ts

@@ -0,0 +1,7 @@
+import { execute, handleCommand } from "../utils"
+export const command = "tabs"
+export const desc = "prints path of all downstream tabs\n"
+export const handlerFn = async (...args: any) => {
+  execute("pwd", ...args)
+}
+export const handler = async (yargs: any) => handleCommand({ ...yargs, each: true, hideProgress: true }, handlerFn)

packages/@misk/cli/src/utils/handleCommand.ts

@@ -34,7 +34,7 @@ export const autoUpdate = async () => {
     formattedLog(
       "Auto-Update",
       `updating miskweb CLI from ${packageVersion} to ${latestOnlineVersion ||
-        "latest"}`,
+      "latest"}`,
       "NPM"
     )
     execute("npm install -g @misk/cli")
@@ -47,10 +47,12 @@ export const handleCommand = async (
     e: boolean
     each: boolean
     $0: string
+    hideProgress: boolean
   },
   handlerFn: (...args: any) => void,
   blockedOptions: string[] = []
 ) => {
+  // Node version check
   const { node: nodeVersion } = process.versions
   if (parseInt(nodeVersion.split(".")[0]) !== 10) {
     formattedLog(
@@ -60,21 +62,27 @@ export const handleCommand = async (
     )
   }
   const latestOnlineVersion = await packageVersionExistsOnNPM()
+
+  // CLI version check
   if (
     packageVersion !== latestOnlineVersion &&
     latestOnlineVersion !== PackageVersionStatus.OFFLINE
   ) {
     console.log(
       `[ALERT] Upgrade miskweb CLI from ${packageVersion} to ${latestOnlineVersion ||
-        "latest"} with '$ miskweb update'`
+      "latest"} with '$ miskweb update'`
     )
   }
+
+  // Blocked options (ie. not allowing -e on miskweb start)
   let invalidOptions: string[] = []
   blockedOptions.map((opt: string) => {
     if (opt in args) {
       invalidOptions.push(opt)
     }
   })
+
+  // Execute command
   if (invalidOptions.length > 0) {
     console.error(
       `Invalid use of ${invalidOptions.map(
@@ -87,29 +95,35 @@ export const handleCommand = async (
       .hide("version")
       .showHelp()
   } else if (args.each) {
-    const bar = new ProgressBar(`[EACH][:bar]`, {
-      complete: "=",
-      incomplete: " ",
-      width: 80,
-      total: 10
-    })
+    // Find all downstream tabs and execute command in that tab directory
+    let bar: any = null
+    if (!args.hideProgress) {
+      bar = new ProgressBar(`[EACH][:bar]`, {
+        complete: "=",
+        incomplete: " ",
+        width: 80,
+        total: 10
+      })
+    }
+
     const tabs: string[] = []
     klaw(".", { filter: filterFunc })
       .on("data", (item: any) => {
         if (item.stats.isFile() && item.path.includes("/miskTab.json")) {
-          if (tabs.length < 10) bar.tick(1)
+          if (!args.hideProgress && tabs.length < 10) bar.tick(1)
           tabs.push(item.path.split("/miskTab.json")[0])
         }
       })
       .on("error", (err: Error) => console.error(err))
       .on("end", async () => {
-        bar.tick(10 - tabs.length)
+        if (!args.hideProgress) bar.tick(10 - tabs.length)
         for (const tab in tabs) {
           cd(tabs[tab])
           handlerFn({ ...args, dir: tabs[tab] })
         }
       })
   } else {
+    // Execute command in current directory
     handlerFn(args)
   }
 }

packages/@misk/common/CHANGELOG.json

@@ -1,6 +1,12 @@
 {
   "name": "@misk/common",
   "entries": [
+    {
+      "version": "0.1.8",
+      "tag": "@misk/common_v0.1.8",
+      "date": "Thu, 11 Jul 2019 17:39:26 GMT",
+      "comments": {}
+    },
     {
       "version": "0.1.7",
       "tag": "@misk/common_v0.1.7",

packages/@misk/common/CHANGELOG.md

@@ -1,6 +1,11 @@
 # Change Log - @misk/common
 
-This log was last generated on Fri, 28 Jun 2019 14:39:38 GMT and should not be manually modified.
+This log was last generated on Thu, 11 Jul 2019 17:39:26 GMT and should not be manually modified.
+
+## 0.1.8
+Thu, 11 Jul 2019 17:39:26 GMT
+
+*Version update only*
 
 ## 0.1.7
 Fri, 28 Jun 2019 14:39:38 GMT

packages/@misk/common/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@misk/common",
-  "version": "0.1.7",
+  "version": "0.1.8",
   "license": "SEE LICENSE IN https://github.com/cashapp/misk-web",
   "description": "Misk-Web Common Libraries, Styles",
   "author": "CashApp/Misk-Web Authors (https://github.com/cashapp/misk-web/graphs/contributors)",
@@ -66,8 +66,8 @@
     "styled-components": "4.3.2"
   },
   "devDependencies": {
-    "@misk/dev": "0.1.7",
-    "@misk/tslint": "0.1.7",
+    "@misk/dev": "0.1.8",
+    "@misk/tslint": "0.1.8",
     "@types/history": "4.7.2",
     "@types/lodash": "4.14.134",
     "@types/node": "11.13.1",

packages/@misk/core/CHANGELOG.json

@@ -1,6 +1,12 @@
 {
   "name": "@misk/core",
   "entries": [
+    {
+      "version": "0.1.8",
+      "tag": "@misk/core_v0.1.8",
+      "date": "Thu, 11 Jul 2019 17:39:26 GMT",
+      "comments": {}
+    },
     {
       "version": "0.1.7",
       "tag": "@misk/core_v0.1.7",

packages/@misk/core/CHANGELOG.md

@@ -1,6 +1,11 @@
 # Change Log - @misk/core
 
-This log was last generated on Fri, 28 Jun 2019 14:39:38 GMT and should not be manually modified.
+This log was last generated on Thu, 11 Jul 2019 17:39:26 GMT and should not be manually modified.
+
+## 0.1.8
+Thu, 11 Jul 2019 17:39:26 GMT
+
+*Version update only*
 
 ## 0.1.7
 Fri, 28 Jun 2019 14:39:38 GMT