Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add props to Navbar to customize MenuButton #574

Merged
merged 2 commits into from Sep 11, 2019

Conversation

@adrw
Copy link
Collaborator

commented Sep 10, 2019

  • Add to @misk/test library "@testing-library/dom" for easier tests
  • New props added to Navbar to customize MenuButton
menuIcon?: IconName | JSX.Element | string
menuOpenIcon?: IconName | JSX.Element | string
menuButtonAsLink?: boolean
menuShowButton?: boolean

@adrw adrw force-pushed the adrw:adrw/20190910.572 branch 3 times, most recently from 00d6767 to f4b3dad Sep 10, 2019

adrw added 2 commits Sep 10, 2019
Add props to Navbar to customize MenuButton
* Add to `@misk/test` library "@testing-library/dom" for easier tests
* New props added to Navbar to customize MenuButton

```
menuIcon?: IconName | JSX.Element | string
menuOpenIcon?: IconName | JSX.Element | string
menuButtonAsLink?: boolean
menuShowButton?: boolean
```

* [CLOSES #572]

@adrw adrw force-pushed the adrw:adrw/20190910.572 branch from 5fc36f6 to 019341b Sep 11, 2019

@adrw adrw merged commit e06ddc2 into cashapp:master Sep 11, 2019

3 checks passed

ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: java Your tests passed on CircleCI!
Details
ci/circleci: node Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.