-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix configuration cache bug when generating sources #1424
Merged
jrodbx
merged 1 commit into
master
from
jrod/2024-05-13/configuration-cache-for-generated-sources
May 14, 2024
Merged
Fix configuration cache bug when generating sources #1424
jrodbx
merged 1 commit into
master
from
jrod/2024-05-13/configuration-cache-for-generated-sources
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TWiStErRob
reviewed
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, thanks for looking! A few thoughts, and questions.
paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Outdated
Show resolved
Hide resolved
paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Outdated
Show resolved
Hide resolved
paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Outdated
Show resolved
Hide resolved
paparazzi-gradle-plugin/src/test/projects/configuration-cache-generated-sources/build.gradle
Outdated
Show resolved
Hide resolved
paparazzi-gradle-plugin/src/test/projects/configuration-cache-generated-sources/build.gradle
Outdated
Show resolved
Hide resolved
4951515
to
ce44f08
Compare
Defers fetching of file collection elements during task configuration Closes #1376
ce44f08
to
d014cbf
Compare
geoff-powell
approved these changes
May 13, 2024
jrodbx
added a commit
that referenced
this pull request
Jul 5, 2024
jrodbx
added a commit
that referenced
this pull request
Jul 5, 2024
jrodbx
added a commit
that referenced
this pull request
Jul 5, 2024
jrodbx
pushed a commit
that referenced
this pull request
Jul 6, 2024
* Delete MatrixMultiplication Interceptor (#1423) * Fix configuration cache bug when generating sources (#1424) * Invert logic in #1388 (#1425) * Remove guava workaround now that Collector APIs are in guava-android (#1426) * Extract aar2jar logic into shareable plugin (#1435) * Update dependency com.android.tools.layoutlib:layoutlib-api to v31.4.1 (#1401) * Update dependency dev.drewhamilton.poko:poko-gradle-plugin to v0.15.3 (#1438) * Fix recent tests to be repeatable (#1436) * Remove JUnit usages from files in main source set (#1437) * Update Kotlin and Compose (#1385)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defers fetching of file collection elements during task configuration. Closes #1376.