Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration cache bug when generating sources #1424

Merged

Conversation

jrodbx
Copy link
Collaborator

@jrodbx jrodbx commented May 13, 2024

Defers fetching of file collection elements during task configuration. Closes #1376.

Copy link
Contributor

@TWiStErRob TWiStErRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks for looking! A few thoughts, and questions.

@jrodbx jrodbx force-pushed the jrod/2024-05-13/configuration-cache-for-generated-sources branch 2 times, most recently from 4951515 to ce44f08 Compare May 13, 2024 20:04
Defers fetching of file collection elements during task configuration
Closes #1376
@jrodbx jrodbx force-pushed the jrod/2024-05-13/configuration-cache-for-generated-sources branch from ce44f08 to d014cbf Compare May 13, 2024 20:18
@jrodbx jrodbx merged commit 3d94ca0 into master May 14, 2024
14 checks passed
@jrodbx jrodbx deleted the jrod/2024-05-13/configuration-cache-for-generated-sources branch May 14, 2024 00:03
jrodbx pushed a commit that referenced this pull request Jul 6, 2024
* Delete MatrixMultiplication Interceptor (#1423)
* Fix configuration cache bug when generating sources (#1424)
* Invert logic in #1388 (#1425)
* Remove guava workaround now that Collector APIs are in guava-android (#1426)
* Extract aar2jar logic into shareable plugin (#1435)
* Update dependency com.android.tools.layoutlib:layoutlib-api to v31.4.1 (#1401)
* Update dependency dev.drewhamilton.poko:poko-gradle-plugin to v0.15.3 (#1438)
* Fix recent tests to be repeatable (#1436)
* Remove JUnit usages from files in main source set (#1437)
* Update Kotlin and Compose (#1385)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.3.4-SNAPSHOT causes configuration cache error when used with Google Services
3 participants