Remove JUnit usages from files in main source set #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TWiStErRob
reviewed
May 18, 2024
paparazzi/src/main/java/app/cash/paparazzi/internal/ImageUtils.kt
Outdated
Show resolved
Hide resolved
JakeWharton
approved these changes
May 21, 2024
paparazzi/src/main/java/app/cash/paparazzi/internal/ImageUtils.kt
Outdated
Show resolved
Hide resolved
paparazzi/src/main/java/app/cash/paparazzi/internal/ImageUtils.kt
Outdated
Show resolved
Hide resolved
paparazzi/src/main/java/app/cash/paparazzi/internal/ImageUtils.kt
Outdated
Show resolved
Hide resolved
jrodbx
force-pushed
the
jrod/2024-05-18/junit-removal
branch
from
42a85d1
to
ff8270e
Compare
jrodbx
force-pushed
the
jrod/2024-05-18/junit-removal
branch
from
ff8270e
to
e4860ea
Compare
jrodbx
added a commit
that referenced
this pull request
Jul 5, 2024
jrodbx
added a commit
that referenced
this pull request
Jul 5, 2024
jrodbx
added a commit
that referenced
this pull request
Jul 5, 2024
jrodbx
pushed a commit
that referenced
this pull request
Jul 6, 2024
* Delete MatrixMultiplication Interceptor (#1423) * Fix configuration cache bug when generating sources (#1424) * Invert logic in #1388 (#1425) * Remove guava workaround now that Collector APIs are in guava-android (#1426) * Extract aar2jar logic into shareable plugin (#1435) * Update dependency com.android.tools.layoutlib:layoutlib-api to v31.4.1 (#1401) * Update dependency dev.drewhamilton.poko:poko-gradle-plugin to v0.15.3 (#1438) * Fix recent tests to be repeatable (#1436) * Remove JUnit usages from files in main source set (#1437) * Update Kotlin and Compose (#1385)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
paparazzimodule has been designed as a JUnit rule, so it's been tempting to use Junit assertions in both test sources as well as main sources. However, moving core classes out into an SDK non-JUnit module reveals the tight coupling in some classes, so let's fix that.