Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract aar2jar logic into shareable plugin #1435

Merged
merged 1 commit into from
May 16, 2024
Merged

Extract aar2jar logic into shareable plugin #1435

merged 1 commit into from
May 16, 2024

Conversation

jrodbx
Copy link
Collaborator

@jrodbx jrodbx commented May 16, 2024

Some minor things to clean up, but I think I like how this is looking.

@jrodbx jrodbx requested a review from geoff-powell May 16, 2024 08:45
@jrodbx jrodbx force-pushed the jrod/2024-05-14/shareable-aar2jar-logic branch from eb6336e to 4026aee Compare May 16, 2024 08:46
@jrodbx jrodbx force-pushed the jrod/2024-05-14/shareable-aar2jar-logic branch from 4026aee to 7e99dd3 Compare May 16, 2024 17:46
@jrodbx jrodbx marked this pull request as ready for review May 16, 2024 17:50
@jrodbx jrodbx force-pushed the jrod/2024-05-14/shareable-aar2jar-logic branch from 7e99dd3 to da99f5b Compare May 16, 2024 20:30
@jrodbx jrodbx merged commit a205508 into master May 16, 2024
14 checks passed
@jrodbx jrodbx deleted the jrod/2024-05-14/shareable-aar2jar-logic branch May 16, 2024 20:43
@TWiStErRob
Copy link
Contributor

@jrodbx Are you planning to publish this at one point?

@jrodbx
Copy link
Collaborator Author

jrodbx commented May 16, 2024

@jrodbx Are you planning to publish this at one point?

Hadn't considered it, but could! Would you find it useful?

@TWiStErRob
Copy link
Contributor

I would, if it solves the following (yet to try):

Recently I had to bump a module from kotlin-library to android-library:
TWiStErRob/net.twisterrob.astro@14a0fbb#diff-e560ab5b481520f07c70edf4be9724d3b19aada99c2308249bdbefc047993c32R2

because a dependency (:test-base-compose) is an android-library:
TWiStErRob/net.twisterrob.astro@14a0fbb#diff-ce5319610e382c1f6f53ed10bee8d7f6e19aa67e2771792e34707b4e9029f779

because it depends on Espresso Core, which is an AAR:
https://mvnrepository.com/artifact/androidx.test.espresso/espresso-core/3.5.1

As far as I understand if I apply this plugin on the :test-base-compose, I can keep it a kotlin-library and therefore have less AGP modules, especially low-level ones that are referenced everywhere.

jrodbx added a commit that referenced this pull request Jul 5, 2024
@jrodbx
Extract aar2jar logic into shareable plugin (#1435)
c61b296
jrodbx added a commit that referenced this pull request Jul 5, 2024
@jrodbx
Extract aar2jar logic into shareable plugin (#1435)
b6063b3
jrodbx added a commit that referenced this pull request Jul 5, 2024
@jrodbx
Extract aar2jar logic into shareable plugin (#1435)
30a8878
jrodbx pushed a commit that referenced this pull request Jul 6, 2024
@gamepro65 @jrodbx
Cherry-pick a few changes after onPreDraw change
f81e9c7 
* Delete MatrixMultiplication Interceptor (#1423)
* Fix configuration cache bug when generating sources (#1424)
* Invert logic in #1388 (#1425)
* Remove guava workaround now that Collector APIs are in guava-android (#1426)
* Extract aar2jar logic into shareable plugin (#1435)
* Update dependency com.android.tools.layoutlib:layoutlib-api to v31.4.1 (#1401)
* Update dependency dev.drewhamilton.poko:poko-gradle-plugin to v0.15.3 (#1438)
* Fix recent tests to be repeatable (#1436)
* Remove JUnit usages from files in main source set (#1437)
* Update Kotlin and Compose (#1385)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoff-powell geoff-powell geoff-powell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrodbx @TWiStErRob @geoff-powell