Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kotlin monorepo to v1.8.0 #3752

Merged
merged 10 commits into from
Jan 4, 2023
Merged

Update kotlin monorepo to v1.8.0 #3752

merged 10 commits into from
Jan 4, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 28, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.jetbrains.kotlin.js (source) 1.7.22 -> 1.8.0 age adoption passing confidence
org.jetbrains.kotlin.jvm (source) 1.7.22 -> 1.8.0 age adoption passing confidence
org.jetbrains.kotlin.android (source) 1.7.22 -> 1.8.0 age adoption passing confidence
org.jetbrains.kotlin.native.cocoapods (source) 1.7.22 -> 1.8.0 age adoption passing confidence
org.jetbrains.kotlin.multiplatform (source) 1.7.22 -> 1.8.0 age adoption passing confidence
org.jetbrains.kotlin:kotlin-gradle-plugin (source) 1.7.22 -> 1.8.0 age adoption passing confidence
org.jetbrains.kotlin:kotlin-test-js (source) 1.7.22 -> 1.8.0 age adoption passing confidence
org.jetbrains.kotlin:kotlin-test-junit (source) 1.7.22 -> 1.8.0 age adoption passing confidence
org.jetbrains.kotlin:kotlin-test (source) 1.7.22 -> 1.8.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Copy link
Contributor Author

renovate bot commented Dec 29, 2022

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@hfhbd
Copy link
Collaborator

hfhbd commented Dec 29, 2022

I finally understand the problem:
Kotlin 1.8 adds a new yarn.lock validation feature to prevent changed yarn lock files for better reproducibility and security (and so on). Unfortunately, there is only 1 global lock file, but different projects have different npm dependencies, for example, nodejs requires some local file dependencies or browser requires webpack plugins.

When running the CI excluding different subprojects, the remaining projects do not include all dependencies, so the yarn file changed and is invalid now.
But I am actually unable to create a small reproducer.

There is a workaround too: Disable the yarn lock file check.

@hfhbd
Copy link
Collaborator

hfhbd commented Dec 29, 2022

Alternative workaround: Disable configureondemand.
Without configureondemand the yarn lock file contains all globally dependencies, not the actually ones from the required projects only.

@hfhbd
Copy link
Collaborator

hfhbd commented Dec 29, 2022

Now building the sample fails, reason https://youtrack.jetbrains.com/issue/KT-52172/Multiplatform-Support-composite-builds:

* What went wrong:
Could not determine the dependencies of task ':common:compileCommonMainKotlinMetadata'.
> java.nio.file.NoSuchFileException: /Users/runner/work/sqldelight/sqldelight/runtime/build/libs/runtime-metadata-2.0.0-SNAPSHOT.jar

* Try:
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Exception is:
org.gradle.api.internal.tasks.TaskDependencyResolveException: Could not determine the dependencies of task ':common:compileCommonMainKotlinMetadata'.

.github/workflows/PR.yml Outdated Show resolved Hide resolved
gradle.properties Outdated Show resolved Hide resolved
hfhbd and others added 2 commits January 3, 2023 20:39
Co-authored-by: Derek Ellis <derekellis@squareup.com>
@dellisd
Copy link
Collaborator

dellisd commented Jan 4, 2023

The configureondemand option probably needs to be removed from all of the workflow files, doesn't it?

@hfhbd
Copy link
Collaborator

hfhbd commented Jan 4, 2023

Oh, yes!

@dellisd
Copy link
Collaborator

dellisd commented Jan 4, 2023

Looks good to merge for me, was there anything else we needed to wait on?

@hfhbd
Copy link
Collaborator

hfhbd commented Jan 4, 2023

I don't think so.

@dellisd dellisd merged commit c590388 into master Jan 4, 2023
@dellisd dellisd deleted the renovate/kotlin-monorepo branch January 4, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants