-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Kotlin to 1.8. #855
Conversation
c3f5226
to
2850b84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Maybe in the time between now and our requirements for this merging being met we can try to fix some the FIR incompatibilities. I assume it's mostly our heavy use of FqName
and APIs which take an FqName
?
@JakeWharton Yep, it's all due to using the |
bcedb87
to
fe4f077
Compare
Tests pass! Okay, this is good to go once SqlDelight has a release that supports Kotlin 1.8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent
zipline-gradle-plugin/src/test/projects/signing/build.gradle.kts
Outdated
Show resolved
Hide resolved
zipline-gradle-plugin/src/test/projects/signing/build.gradle.kts
Outdated
Show resolved
Hide resolved
zipline-gradle-plugin/src/test/projects/multipleJsTargets/build.gradle.kts
Outdated
Show resolved
Hide resolved
zipline-gradle-plugin/src/test/projects/multipleJsTargets/build.gradle.kts
Outdated
Show resolved
Hide resolved
zipline-gradle-plugin/src/test/projects/jvmOnly/build.gradle.kts
Outdated
Show resolved
Hide resolved
zipline-gradle-plugin/src/test/projects/jvmOnly/build.gradle.kts
Outdated
Show resolved
Hide resolved
Co-authored-by: Jake Wharton <jw@squareup.com>
Co-authored-by: Jake Wharton <jw@squareup.com>
Co-authored-by: Jake Wharton <jw@squareup.com>
Co-authored-by: Jake Wharton <jw@squareup.com>
…d.gradle.kts Co-authored-by: Jake Wharton <jw@squareup.com>
…d.gradle.kts Co-authored-by: Jake Wharton <jw@squareup.com>
Co-authored-by: Jake Wharton <jw@squareup.com>
Co-authored-by: Jake Wharton <jw@squareup.com>
Co-authored-by: Jake Wharton <jw@squareup.com>
Co-authored-by: Jake Wharton <jw@squareup.com>
This reverts commit 43775e7.
Resolves: #834
Blocked by:
1.5
branch.A 1.8-compatible Compose compiler version is released. This branch currently uses a snapshot release. This maybe isn't necessary since the compiler is only used in the sample app.Tested this branch with the world clock sample and everything works!