Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 5372 add alias to json table function #5375

Merged
merged 2 commits into from
Jul 26, 2024
Merged

fix 5372 add alias to json table function #5375

merged 2 commits into from
Jul 26, 2024

Conversation

griffio
Copy link
Contributor

@griffio griffio commented Jul 25, 2024 •
edited
Loading

fixes #5372

  • Add grammar for alias
  • Update mixin to use table alias if available
  • Add fixture test
  • Update integration test to include use of alias

@griffio griffio marked this pull request as ready for review July 25, 2024 16:30
@griffio
fix 5372 add alias
5fac4c2 
Add grammar for alias
Update mixin to use table alias if available
Add fixture test
@griffio
Update JsonTable.sq
d23846f 
Add use of alias for json function
@griffio griffio force-pushed the fix-5372-sqlite-json-table branch from 4eeb1f5 to d23846f Compare July 26, 2024 08:06
@JakeWharton JakeWharton enabled auto-merge (squash) July 26, 2024 12:36
@JakeWharton JakeWharton merged commit c4084ee into sqldelight:master Jul 26, 2024
11 checks passed
@griffio griffio deleted the fix-5372-sqlite-json-table branch July 26, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeWharton JakeWharton JakeWharton approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

json_each results cannot be named
2 participants
@griffio @JakeWharton