-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish adding SQLite support #2
Comments
Here are my current ideas:
|
Commerce plant is old and used the older mysql_query() structures. ALL db queries should be routed through CASHDBA or we don't accept the patch. Centralized PDO is the only civilized way. |
Just wondering: is it possible for the mysql binary to not be found, but for PDO to still work? It would be nice to be able to detect people that attempt to install CM that don't have mysql support. Is it possible to have PDO, but it not supporting MySQL? Probably a rare situation, in any case, but it is nice to be defensive and warn users early instead of giving cryptic errors. |
Not 100% sure about this, but I'm pretty sure both PDO and SQLite wouldn't report as available unless their binaries were present at compile time. We can probably test with:
and
http://www.php.net/manual/en/class.pdo.php |
Yeah, defined checks for the objects sounds reasonable. |
This could be useful: PDO::getAvailableDrivers() |
removed old cashmusic.js, pulled in latest (uncompressed) version, ditch...
Currently we have a SQLite schema in our repo, and instructions for creating a DB from it and regenerating the SQLite schema when it changes. Now we need to actually support it in the installer and DIY web interface.
The text was updated successfully, but these errors were encountered: