Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Make buffer size configurable #3

Closed
randallpittman opened this issue Feb 23, 2018 · 2 comments
Closed

[Proposal] Make buffer size configurable #3

randallpittman opened this issue Feb 23, 2018 · 2 comments

Comments

@randallpittman
Copy link
Contributor

Especially for transferring to a network share, it may be advantageous to have a larger buffer size. I got a 33% speed increase transferring a 740 G file over gigabit to a samba share (Win XP VM to CentOS host) by bumping up the buffer size to as much a 4MiB. I propose making a module-level variable in pyrocopy.py that is used in _copyFile() to set the buffer size in kiB.

@randallpittman
Copy link
Contributor Author

Default can still be 16, ofc. This seems to be a good value for same-disk operations.

@caskater4
Copy link
Owner

PR merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants