Add borgbackup v0.26.1

[rmoriz]

https://github.com/borgbackup/borg

[vitorgalvao]

Are you sure this is needed?

[rmoriz]

It's just the binary without any container (tar, dmg) and naked is not auto-detected https://github.com/caskroom/homebrew-cask/blob/master/lib/hbc/container.rb

$ wget https://github.com/borgbackup/borg/releases/download/0.26.1/borg-macosx64 
…
$ file borg-macosx64 
borg-macosx64: Mach-O 64-bit executable x86_64

[anarcat]

this is outdated: the latest borg release is 0.28.1.

[rmoriz]

@anarcat can you provide binaries for 0.28.1? Maintainer and gpg signee has not released binaries yet: https://github.com/borgbackup/borg/releases

[vitorgalvao]

This blank line shouldn’t be here.

[rmoriz]

I used the gpg-example from the docs which references https://github.com/caskroom/homebrew-cask/blob/master/Casks/libreoffice.rb including the blank line between the gpg and name part?

Also neither https://github.com/caskroom/homebrew-cask/blob/master/CONTRIBUTING.md#style-guide nor Rubocop have problems with the blank line, you may want to document this better for future contributors…

[anarcat]

@rmoriz i asked the main dev for an update - @ThomasWaldmann: where are the binaries for 0.28.1?

[anarcat]

@rmoriz in the meantime, there are binaries for 0.27...

[adidalal]

Note for maintainers: This is on hold until upstream binaries for v0.28.1 are created and the Cask updated accordingly.

Alternatively, if @rmoriz wants to update the cask to v0.27, this PR can be merged (and a new one opened when binaries for the latest version become available)

[anarcat]

0.28.2 was published with binaries.

[adidalal]

Thank you for the contribution. It needed some fixes, so they were made in 47b865e. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.

@anarcat I forgot to change the commit message, but 0.28.2 is the version included in homebrew cask now.

[raxod502]

Given that Borg is an open-source command-line tool, why is it in Cask instead of Homebrew proper?

[commitay]

@raxod502 Please don't post comments on PRs that are over two years old.

If this can be added to homebrew/core submit a PR and it will be removed from cask.