Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building casper-client-rs requires git as a build dependency #163

Closed
marijanp opened this issue May 24, 2024 · 0 comments · Fixed by #175
Closed

Building casper-client-rs requires git as a build dependency #163

marijanp opened this issue May 24, 2024 · 0 comments · Fixed by #175
Assignees
@gRoussac

Comments

@marijanp
Copy link

I should not be required to install git prior to building a crate.

casper-client-rs/build.rs

Lines 7 to 12 in 6b61f16

let git_process_output = Command::new("git")
.arg("rev-parse")
.arg("--short")
.arg("HEAD")
.output()
.expect("Failed to retrieve short git commit hash");

gRoussac added a commit to gRoussac/casper-client-rs that referenced this issue Jun 18, 2024
@gRoussac
casper-ecosystem#163 Handle git dependency in build.rs
8f3cd23
@gRoussac gRoussac linked a pull request Jun 18, 2024 that will close this issue
#163 Handle git dependency in build.rs #175
Merged
@gRoussac gRoussac self-assigned this Jun 18, 2024
gRoussac added a commit that referenced this issue Jul 16, 2024
@gRoussac @jacek-casper
#163 Handle git dependency in build.rs (#175)
7049b8e 
* #163 Handle git dependency in build.rs

* warning litteral

* println

Co-authored-by: jacek-casper <145967538+jacek-casper@users.noreply.github.com>

---------

Co-authored-by: jacek-casper <145967538+jacek-casper@users.noreply.github.com>
@gRoussac gRoussac mentioned this issue Sep 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gRoussac gRoussac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#163 Handle git dependency in build.rs gRoussac/casper-client-rs
2 participants
@gRoussac @marijanp