Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update current erc20 library + Remove a doc comment #52

Merged
merged 10 commits into from
Dec 21, 2022

Conversation

gRoussac
Copy link
Contributor

@gRoussac gRoussac commented Dec 19, 2022

Update lib for

#39

Remove legacy command in comments

#49

@gRoussac gRoussac changed the title Update lib Update current erc20 library Dec 19, 2022
casper-ecosystem#39

Remove leagcy command

casper-ecosystem#49

# Conflicts:
#	Cargo.lock
#	Cargo.toml

# Conflicts:
#	docs/TUTORIAL.md
@gRoussac gRoussac marked this pull request as ready for review December 19, 2022 13:57
@gRoussac gRoussac mentioned this pull request Dec 19, 2022
@gRoussac gRoussac changed the title Update current erc20 library Update current erc20 library + Remove a doc comments Dec 19, 2022
# Conflicts:
#	erc20/src/lib.rs
@gRoussac gRoussac added bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists labels Dec 19, 2022
Copy link
Contributor

@AlexanderLimonov AlexanderLimonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

Copy link
Contributor

@ipopescu ipopescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, @gRoussac. LGTM! I'll leave the approval to the devs :).

docs/TUTORIAL.md Outdated Show resolved Hide resolved
@@ -281,22 +284,26 @@ casper-client put-deploy \
--secret-key "/home/ubuntu/secret_key.pem" \
--payment-amount 1000000 \
--session-path "<machine-path>/erc20/target/wasm32-unknown-unknown/release/erc20_test.wasm"
--session-arg "name='Token test', symbol='TEST', decimals:u8=10, total_supply:u256=1000"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
Copy link
Contributor

@deuszex deuszex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests run green, lint is good also.

@gRoussac gRoussac changed the base branch from master to dev December 20, 2022 16:31
@gRoussac gRoussac changed the title Update current erc20 library + Remove a doc comments Update current erc20 library + Remove a doc comment Dec 20, 2022
@gRoussac gRoussac merged commit 8b026c0 into casper-ecosystem:dev Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants