-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update current erc20 library + Remove a doc comment #52
Update current erc20 library + Remove a doc comment #52
Conversation
casper-ecosystem#39 Remove leagcy command casper-ecosystem#49 # Conflicts: # Cargo.lock # Cargo.toml # Conflicts: # docs/TUTORIAL.md
a8a220c
to
213f236
Compare
# Conflicts: # erc20/src/lib.rs
0651ea8
to
99c7797
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, @gRoussac. LGTM! I'll leave the approval to the devs :).
@@ -281,22 +284,26 @@ casper-client put-deploy \ | |||
--secret-key "/home/ubuntu/secret_key.pem" \ | |||
--payment-amount 1000000 \ | |||
--session-path "<machine-path>/erc20/target/wasm32-unknown-unknown/release/erc20_test.wasm" | |||
--session-arg "name='Token test', symbol='TEST', decimals:u8=10, total_supply:u256=1000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tests run green, lint is good also.
Update lib for
#39
Remove legacy command in comments
#49