Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An option to get free pascal standard units paths from build tool #564

Merged
merged 3 commits into from
Jan 29, 2024
Merged

An option to get free pascal standard units paths from build tool #564

merged 3 commits into from
Jan 29, 2024

Conversation

and3md
Copy link
Contributor

@and3md and3md commented Jan 29, 2024

Added an option to get free pascal standard units paths used by vscode extension when freepascal installation does not have fpc.cfg.

michaliskambi
michaliskambi requested changes Jan 29, 2024
View reviewed changes
Copy link
Member

@michaliskambi michaliskambi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I only have a request to change

  • FpcStandardUnitsPaths -> FpcStandardUnitsPath ,
  • fpc-standard-units-paths -> fpc-standard-units-path

That is, without s at the end, as this is one path, and the FindExeFpcCompiler parameter is also called like that.

@michaliskambi michaliskambi merged commit 6243303 into master Jan 29, 2024
31 of 32 checks passed
@michaliskambi michaliskambi deleted the fpc_standard_units_paths branch January 29, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaliskambi michaliskambi michaliskambi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@and3md @michaliskambi