-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/492 add project icon to common props #493
Feature/492 add project icon to common props #493
Conversation
Please dont complete. The AppVeyor is not added the "icon" / prakageicon to the nuspec. Maybe old msbuild? |
@generik0, I noticed too that the icon doesn't appear to work, at least not in VS2017 which I'm still using. I've converted this PR to a "draft" (to prevent accidental merging) until this has been resolved. Hope that's OK with you. |
@stakx That’s perfect thanks! |
If you're thinking of the CI build, that would be done by changing Lines 1 to 2 in 0d12f9c
AppVeyor keeps a list of available worker images, which includes one called Our CI build is currently broken due to a regression in Mono, perhaps it would be best to get that fixed first, and upgrade to the newer Visual Studio 2019 image at the same time. (Are you positive that using the newer VS 2019 tooling will resolve the present issue?) |
Let me know if I can help with anything :-) |
HI @stakx. Sorry about the delay. Busy with work and family. Haven't had the time I needed for anything else (excuses excuses).. |
…ojectIconToCommonProps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I've tested the result in VS2017 and VS2019, and the package icons display correctly in both versions' NuGet Package Manager. Also, the build warning is gone, so I'd say, mission accomplished! 🚀
@generik0, thanks for contributing! Btw., no need to apologise for the delay... we've all got our lives aside from (unpaid!) work on open source projects. It's great you came back to finalize this! :-) |
Remove PackageIconUrl in favour of the new PackageIcon configuration
#492