-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed icon in NuGet package #520
Embed icon in NuGet package #520
Conversation
H @jonorossi looks good locally: But from the build server the project Icon still present.. Very strange. Why would the build be different locally v's appveyor |
@jonorossi This is incredibly strange. The AppVeyor build is not adding the icon to the nuspec. Can it be due to the AppVeyor build using an old nuget/VS version? |
Very possible. We are using VS2017: Line 1 in b12304f
According to AppVeyor's docs, it has "NuGet 4.9.2". |
Can we upgrade to Vs2019? I have not experienced any issues with MSBuild in 2019 vs 2017. All my upgrades went fluently:-) |
Hi @jonorossi. Sorry about the delay. Busy with work and family. Haven't had the time I needed for anything else (excuses excuses).. |
…ojectIconToCommonProps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I haven't tested this change here, but I've verified the same change over at castleproject/Core (in VS 2017 & 2019's NuGet Package Manager console, and in the build script's MSBuild output), so I expect this will be fine, too.
Thanks |
Remove PackageIconUrl in favour of the new PackageIcon configuration
Fixes #518