Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchCollection: setting args.arbitraryScoreTieBreak should disable ScoreTiesAdjusterReranker #801

Closed
lintool opened this issue Sep 10, 2019 · 0 comments · Fixed by #803
Closed

SearchCollection: setting args.arbitraryScoreTieBreak should disable ScoreTiesAdjusterReranker #801

lintool opened this issue Sep 10, 2019 · 0 comments · Fixed by #803

Comments

@lintool
Copy link
Member

lintool commented Sep 10, 2019

If user sets args.arbitraryScoreTieBreak on the command line, we shouldn't run the ScoreTiesAdjusterReranker.
@chriskamphuis chriskamphuis mentioned this issue Sep 12, 2019
Merged
lintool pushed a commit that referenced this issue Sep 12, 2019
@chriskamphuis @lintool
Accurate BM25 support + arbitraryScoreTiesBreak fix (#803)
ca253a4 
+ cmd line option during indexing and search
+ updated ScoresTiesAdjusterReranker to listen to arbitraryScoreTiesBreak argument. fix #801
+ small fix in AccurateBM25Similarity class
+ move IndexArgs class to separate file to be more consistent with SearchArgs
crystina-z pushed a commit to crystina-z/anserini that referenced this issue Oct 28, 2022
@MXueguang
fix bug in unittest (castorini#801)
19cfcfc 
fix bug in unittest for unicoil encoder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accurate BM25 support + arbitraryScoreTiesBreak fix
1 participant
@lintool