Skip to content

Commit

Permalink
Move save_path to global cmdline args
Browse files Browse the repository at this point in the history
  • Loading branch information
achyudh committed Mar 17, 2019
1 parent 16514da commit 4fa8169
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 6 deletions.
3 changes: 2 additions & 1 deletion models/args.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

def get_args():
parser = ArgumentParser(description="PyTorch deep learning models for document classification")

parser.add_argument('--no-cuda', action='store_false', dest='cuda')
parser.add_argument('--gpu', type=int, default=0)
parser.add_argument('--epochs', type=int, default=50)
Expand All @@ -12,6 +13,6 @@ def get_args():
parser.add_argument('--seed', type=int, default=3435)
parser.add_argument('--patience', type=int, default=5)
parser.add_argument('--log-every', type=int, default=10)
parser.add_argument('--save-path', type=str, default='reg_lstm/saves')
parser.add_argument('--data-dir', default=os.path.join(os.pardir, 'Castor-data', 'datasets'))

return parser
6 changes: 4 additions & 2 deletions models/kim_cnn/args.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,12 @@ def get_args():
parser.add_argument('--embed-dim', type=int, default=300)
parser.add_argument('--dropout', type=float, default=0.5)
parser.add_argument('--epoch-decay', type=int, default=15)
parser.add_argument('--word-vectors-dir', default=os.path.join(os.pardir, 'Castor-data', 'embeddings', 'word2vec'))
parser.add_argument('--word-vectors-file', default='GoogleNews-vectors-negative300.txt')
parser.add_argument('--trained-model', type=str, default="")
parser.add_argument('--weight-decay', type=float, default=0)

parser.add_argument('--word-vectors-dir', default=os.path.join(os.pardir, 'Castor-data', 'embeddings', 'word2vec'))
parser.add_argument('--word-vectors-file', default='GoogleNews-vectors-negative300.txt')
parser.add_argument('--save-path', type=str, default=os.path.join('kim_cnn', 'saves'))

args = parser.parse_args()
return args
7 changes: 4 additions & 3 deletions models/reg_lstm/args.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ def get_args():
parser.add_argument('--resume-snapshot', type=str, default=None)
parser.add_argument('--bidirectional', action='store_true')
parser.add_argument('--bottleneck-layer', action='store_true')
parser.add_argument('--single-label', action='store_true')
parser.add_argument('--num-layers', type=int, default=2)
parser.add_argument('--hidden-dim', type=int, default=256)
parser.add_argument('--mode', type=str, default='static', choices=['rand', 'static', 'non-static'])
Expand All @@ -18,8 +17,6 @@ def get_args():
parser.add_argument('--embed-dim', type=int, default=300)
parser.add_argument('--dropout', type=float, default=0.5)
parser.add_argument('--epoch-decay', type=int, default=15)
parser.add_argument('--word-vectors-dir', default=os.path.join(os.pardir, 'Castor-data', 'embeddings', 'word2vec'))
parser.add_argument('--word-vectors-file', default='GoogleNews-vectors-negative300.txt')
parser.add_argument('--trained-model', type=str, default="")
parser.add_argument('--tar', type=float, default=0.0, help="temporal activation regularization")
parser.add_argument('--ar', type=float, default=0.0, help="activation regularization")
Expand All @@ -28,5 +25,9 @@ def get_args():
parser.add_argument('--wdrop', type=float, default=0.0, help="weight drop")
parser.add_argument('--embed-droprate', type=float, default=0.0, help="embedding dropout")

parser.add_argument('--word-vectors-dir', default=os.path.join(os.pardir, 'Castor-data', 'embeddings', 'word2vec'))
parser.add_argument('--word-vectors-file', default='GoogleNews-vectors-negative300.txt')
parser.add_argument('--save-path', type=str, default=os.path.join('reg_lstm', 'saves'))

args = parser.parse_args()
return args

0 comments on commit 4fa8169

Please sign in to comment.