Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor scifact 1 #133

Merged
merged 2 commits into from
Dec 26, 2020
Merged

refactor scifact 1 #133

merged 2 commits into from
Dec 26, 2020

Conversation

ronakice
Copy link
Member

Public-facing links, naming conventions

Copy link
Member

@rodrigonogueira4 rodrigonogueira4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a minor comment.

Co-authored-by: Rodrigo Frassetto Nogueira <rodrigonogueira4@gmail.com>
@ronakice ronakice merged commit b0d8901 into master Dec 26, 2020
@ronakice ronakice deleted the scifact-refactor1 branch December 26, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants