Integrate result class in reranker #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This cl: 1- Changes all the reranking related classes to use Result and ResultsWriter Fixing response analysis script with come in a follow up cl |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cl:
1- Changes all the reranking related classes to use
ResultandResultsWriter2- Instead of separate token_count and prompt_and_responses folders, the ranking exec summary is written in a single folder.
4- In addition to trec value format for the final rerank results, the sorted results file is also stored as a json
3- the evaluation script is fixed
Fixing response analysis script with come in a follow up cl
TESTED=ran run_rank_llm e2e