fix: use STAB flag for items that don't need SPEAR
#4212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
JSON
|
superseded by #4214 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
This is essentially a parallel update to #4211 because turns out I can't just check out the remote and yeet the results of a quick search-in-folder at them if they PR'd from the master branch.
Describe the solution
Replaced use of the
SPEARflag withSTABfor all items I found that do not use reach attacks and therefore have no need to use the former flag, since the above-mentioned PR is set to makeSTABthe only source of the cutting-to-stabbing DT conversion andSPEARwill be reserved for solely the "reach attacks can bypass obstacles" effect. Affects:Test screwdriver already covered by the related PR.
Describe alternatives you've considered
screm
Testing
Used eyes, discord chat rushed me into going "weh" and committing this before I could run all of them through the online linter but fuck it we have autoformat now.
Additional context
Checklist