Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't assign piercing damage to weapons that were previously cutting #4217

Conversation

chaosvolt
Copy link
Member

Purpose of change

So, #4214 was implemented by a script that accidentally converted some polearms from cutting damage to piercing damage.

In addition, mods folder wasn't touched by that PR.

Describe the solution

  1. Fixed makeshift glaive, glaive, naginata, naginata replica, and ji accidentally being converted into piercing weapons. Kept SPEAR flag on them for now.
  2. Added SPEAR flag to naginata fake because the other variants have it. How the fuck the automation script missed that when the item is basically identical to the other two flag-wise is beyond me.
  3. Updated items in mods that I had already set up to fix in fix: use STAB flag for items that don't need SPEAR #4212. Swapped SPEAR for STAB for stirge proboscis, demon spider fang, barbed javelin, TEST sonic screwdriver, and TEST soldering iron
    4, Additionally added STAB flag to fix Biomancer spear, Wicked Bonespear, and wood trident.

Describe alternatives you've considered

  1. It's debatable whether ji should have the SPEAR flag or not, and if so whether halberds are still too bulky to justify it, but I left things as they are for now and just fixed the actual mistakes.
  2. Fixing the migration script. I don't know what actually went wrong with it so.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Used my eyes to confirm I actually removed and/or added the flags I intended to add.

Additional context

Checklist

@github-actions github-actions bot added JSON related to game datas in JSON format. mods PR changes related to mods. labels Feb 10, 2024
@chaosvolt chaosvolt enabled auto-merge (squash) February 10, 2024 20:23
Copy link
Collaborator

@Firestorm01X2 Firestorm01X2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready

@chaosvolt chaosvolt merged commit 33560c6 into cataclysmbnteam:main Feb 10, 2024
10 checks passed
@chaosvolt chaosvolt deleted the i-am-once-again-screaming-about-automation-scripts branch February 10, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants