Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ Armor coverage UI issues #3422

Closed
2 tasks done
chaosvolt opened this issue Oct 14, 2023 · 1 comment · Fixed by #3434
Closed
2 tasks done

☂️ Armor coverage UI issues #3422

chaosvolt opened this issue Oct 14, 2023 · 1 comment · Fixed by #3434
Assignees
Labels
Milestone

Comments

@chaosvolt
Copy link
Member

chaosvolt commented Oct 14, 2023

Describe the bug

This. This thing.
image

In a nutshell:

  1. The numbers aren't aligned properly ewwww
  2. Average coverage is kinda really gonna be useless 90% of the time. Even if coverage actually varies, a high average means absolutely nothing to the player if it's because the limbs have perfect coverage but the vitals are highly exposed, or vice-versa.
  3. Large volume of redundant information anytime we have an item that doesn't actually vary its encumbrance and coverage percent

What needs to be fixed for this, in order:

  1. Fix the spacing on the display info weh!
  2. Either axe average coverage because it's going to be not really that useful to the player most of the time, or else only display it if the actual average is different from all of the values for each body part (though as noted above that's both the only case where it's worth displaying but also the case where it's the most worthless to the player).
  3. If all bodyparts have the exact same info, don't display a detail view for every single part. Just show a "everything has this" line instead.
    3a. Addition to the above, in theory we could even make the detail view even better by grouping all examples found of identical values, e.g. if the torso and head has 100% coverage while the arms and hands have 90% coverage, find some (hopefully not ugly) way to say "head, torso: 100" followed by "arms, hands: 90"

Steps To Reproduce

Exist in a build after and look at the description screen for any armor item, mainly anything that covers more than one body part.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19041.450 (2004)
  • Game Version: 2bc98a8 [64-bit]
  • Graphics Version: Tiles
  • LAPI Version: 1
  • Game Language: []
  • Mods loaded: [
    Bright Nights [bn],
    Arcana and Magic Items [Arcana],
    Cataclysm++ [Cata++],
    Elevated bridges [elevated_bridges],
    Medieval Mod Reborn [Medieval_Mod_Reborn],
    MST Extra [MST_Extra],
    Arcana/Cata++ Patchmod [Arcana_Cata++_Patch],
    Mining Mod [Mining_Mod],
    Tankmod: Revived [Tankmod_Revived],
    No Fungal Monsters [No_Fungi],
    Disable NPC Needs [no_npc_food],
    Faster Stamina Regen [stamina_regen_buff],
    Manual Bionic Installation [manualbionicinstall],
    Nonperishable Overhaul [Nonperishable_Overhaul],
    Simplified Nutrition [novitamins],
    SpeedyDex [speedydex],
    Stats Through Kills [stats_through_kills]
    ]

Additional context

DDA had an issue for exactly this problem way back when, with thanks to @x-qq: CleverRaven/Cataclysm-DDA#59820

The UI shown in the issue OP is somehow even shittier than the version we've ended up with but still, ick. Some of it it seems is due to breathability which mercifully we don't have, but in any case it predictably got closed as invalid because since then they've managed to make their armor UI even more inefficient and hideous:
image
image

Jesus fuckmothering christ I have to pagedown through that and take two separate screenshots to get all that and I've got DDA maximized on a 1920x1080 monitor what in the infinite hells
image

Tasks

@chaosvolt chaosvolt added the bug label Oct 14, 2023
@scarf005 scarf005 self-assigned this Oct 14, 2023
@scarf005 scarf005 added this to the Stable release 4 milestone Oct 14, 2023
@scarf005
Copy link
Member

  @
.-#-.
 / \
 . .

ASCII person goes brrrrrr

@scarf005 scarf005 changed the title Armor coverage UI misaligned, contains redundant info ☂️ Armor coverage UI issues Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants