v22: simplification 2.0 #1395

Scitator · 2022-01-26T05:36:23Z

Pull Request FAQ

documentation
contribution guide
minimal examples section
changelog for main framework updates
Catalyst slack (#__questions channel) for issue discussion

Description

core architecture moved to Animus-like.
engines moved to Accelerate.
config/hydra APIs deprecated in favor of hydra-slayer-custom config runners.
dl-based scripts removed from the API, there is no need in them now
self-supervised runner moved to examples - it's better to have custom still
contrib and utils - truncated
requirements - simplified
codestyle moved to -l 89 (better view on 16'' screen ;) )

Related Issue

Type of Change

Examples / docs / tutorials / contributors update
Bug fix (non-breaking change which fixes an issue)
Improvement (non-breaking change which improves an existing feature)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Checklist

Have you updated tests for the new functionality?
Have you added your new classes/functions to the docs?
Have you updated the CHANGELOG?
Have you run colab minimal CI/CD with latest and minimal requirements?
Have you checked XLA integration with single and multiple processes?

pep8speaks · 2022-01-26T05:36:31Z

Hello @Scitator! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file catalyst/loggers/wandb.py:

Line 225:87: E231 missing whitespace after ','

In the file catalyst/runners/__init__.py:

Line 12:1: E303 too many blank lines (3)

Comment last updated at 2022-01-26 05:47:43 UTC

github-actions · 2022-01-26T05:44:45Z

catalyst/loggers/wandb.py

-                "loader_key": loader_key,
-                "scope": scope,
-            },
+            metadata={"stage_key": stage_key, "loader_key": loader_key, "scope": scope,},


[pep8] _{reported by reviewdog 🐶}
E231 missing whitespace after ','

github-actions · 2022-01-26T05:44:45Z

catalyst/engines/torch.py


-    Args:
-        device: use device, default is `"cpu"`.
+class CPUEngine(IEngine):


[pep8] _{reported by reviewdog 🐶}
D101 Missing docstring in public class

github-actions · 2022-01-26T05:44:45Z

catalyst/engines/torch.py


-    .. code-block:: python
+class GPUEngine(IEngine):


[pep8] _{reported by reviewdog 🐶}
D101 Missing docstring in public class

github-actions · 2022-01-26T05:44:45Z

catalyst/engines/torch.py

-            engine=dl.DeviceEngine("cuda:1"),
-            ...
-        )
+class DataParallelEngine(GPUEngine):


[pep8] _{reported by reviewdog 🐶}
D101 Missing docstring in public class

github-actions · 2022-01-26T05:44:45Z

catalyst/engines/torch.py

-            ...
-        )
+class DataParallelEngine(GPUEngine):
+    def prepare_model(self, model):


[pep8] _{reported by reviewdog 🐶}
D102 Missing docstring in public method

github-actions · 2022-01-26T05:44:46Z

catalyst/core/engine.py


-from catalyst.typing import Criterion, Device, Model, Optimizer, Scheduler
+class IEngine(Accelerator):


[pep8] _{reported by reviewdog 🐶}
D101 Missing docstring in public class

github-actions · 2022-01-26T05:44:46Z

catalyst/core/engine.py

-from catalyst.typing import Criterion, Device, Model, Optimizer, Scheduler
+class IEngine(Accelerator):
+    @staticmethod
+    def spawn(fn: Callable):


[pep8] _{reported by reviewdog 🐶}
D102 Missing docstring in public method

github-actions · 2022-01-26T05:44:46Z

catalyst/core/engine.py

-                Default is `1`.
-        """
+    @staticmethod
+    def setup(local_rank: int, world_size: int):


[pep8] _{reported by reviewdog 🐶}
D102 Missing docstring in public method

github-actions · 2022-01-26T05:44:46Z

catalyst/core/engine.py

-    def cleanup_process(self):
-        """Clean DDP variables and processes."""
+    @staticmethod
+    def cleanup():


[pep8] _{reported by reviewdog 🐶}
D102 Missing docstring in public method

github-actions · 2022-01-26T05:44:46Z

catalyst/core/engine.py

-        Args:
-            tensor_or_module: tensor to mode
-        """
+    def mean_reduce_ddp_metrics(self, metrics: Dict):


[pep8] _{reported by reviewdog 🐶}
D102 Missing docstring in public method

github-actions · 2022-01-27T05:43:21Z

catalyst/core/runner.py

 EPOCH_METRICS = Dict[str, LOADER_METRICS]
+# {0: {"train": {}, "valid": {}}, 1: {...}}
+EXPERIMENT_METRICS = Dict[int, EPOCH_METRICS]  


[pep8] _{reported by reviewdog 🐶}
W291 trailing whitespace

github-actions · 2022-01-28T04:47:24Z

catalyst/runners/runner.py

-        criterion: Criterion = None,
-        optimizer: Optimizer = None,
-        scheduler: Scheduler = None,
+        criterion: TorchCriterion = None,


[pep8] _{reported by reviewdog 🐶}
DAR102 Excess parameter(s) in Docstring: + trial

github-actions · 2022-01-28T06:59:16Z

catalyst/runners/config.py

@@ -195,7 +195,7 @@ def get_engine(self) -> IEngine:
            engine = REGISTRY.get_from_params(**engine_params)
        else:
            engine = get_available_engine(
-                fp16=self._fp16, ddp=self._ddp, amp=self._amp, apex=self._apex
+                fp16=self._fp16, ddp=self._ddp, fp16=self._amp, apex=self._apex


[pep8] _{reported by reviewdog 🐶}
E999 SyntaxError: keyword argument repeated

github-actions · 2022-01-28T06:59:17Z

catalyst/contrib/runners/self_supervised.py

+
+    def __init__(
+        self,
+        model: RunnerModel = None,


[pep8] _{reported by reviewdog 🐶}
F821 undefined name 'RunnerModel'

github-actions · 2022-01-28T06:59:17Z

catalyst/contrib/runners/self_supervised.py

+    def __init__(
+        self,
+        model: RunnerModel = None,
+        engine: IEngine = None,


[pep8] _{reported by reviewdog 🐶}
F821 undefined name 'IEngine'

github-actions · 2022-01-28T06:59:17Z

catalyst/contrib/runners/self_supervised.py

+        Runner.__init__(self, model=model, engine=engine)
+        self.loss_mode_prefix = loss_mode_prefix
+
+    @torch.no_grad()


[pep8] _{reported by reviewdog 🐶}
F821 undefined name 'torch'

github-actions · 2022-01-28T06:59:17Z

catalyst/contrib/runners/self_supervised.py

+        output = self.forward(batch, **kwargs)
+        return output
+
+    def get_callbacks(self) -> "OrderedDict[str, Callback]":


[pep8] _{reported by reviewdog 🐶}
F821 undefined name 'OrderedDict'

github-actions · 2022-01-28T06:59:19Z

catalyst/callbacks/checkpoint.py

+        self._storage: List[Checkpoint] = []
+        os.makedirs(self.logdir, exist_ok=True)
+
+    def save(self, runner: "IRunner", obj: Any, logprefix: str) -> str:


[pep8] _{reported by reviewdog 🐶}
D102 Missing docstring in public method

github-actions · 2022-01-28T06:59:20Z

catalyst/callbacks/checkpoint.py

+        """Event handler."""
+        self._storage: List[Checkpoint] = []
+
+    def on_epoch_end_best(self, runner: "IRunner") -> None:


[pep8] _{reported by reviewdog 🐶}
D102 Missing docstring in public method

github-actions · 2022-01-28T06:59:20Z

catalyst/callbacks/checkpoint.py

-            # worker sync
-            runner.engine.barrier()
-            return
+    def on_epoch_end_last(self, runner: "IRunner") -> None:


[pep8] _{reported by reviewdog 🐶}
D102 Missing docstring in public method

github-actions · 2022-01-28T06:59:20Z

catalyst/callbacks/optimizer.py

@@ -2,7 +2,7 @@
 from functools import partial
 import logging

-from catalyst.core.callback import CallbackNode, CallbackOrder, IOptimizerCallback
+from catalyst.core.callback import CallbackOrder, IOptimizerCallback


[pep8] _{reported by reviewdog 🐶}
F401 'catalyst.core.callback.CallbackOrder' imported but unused

github-actions · 2022-01-28T06:59:20Z

catalyst/core/runner.py

 import logging
-import warnings
+
+from accelerate.state import DistributedType


[pep8] _{reported by reviewdog 🐶}
F401 'accelerate.state.DistributedType' imported but unused

github-actions · 2022-01-31T06:11:22Z

catalyst/runners/runner.py

@@ -852,8 +537,8 @@ def predict_batch(self, batch: Mapping[str, Any], **kwargs) -> Mapping[str, Any]
        Run model inference on specified data batch.

        .. warning::
-            You should not override this method. If you need specific model
-            call, override forward() method
+            You should not override this method. 


[pep8] _{reported by reviewdog 🐶}
W291 trailing whitespace

github-actions · 2022-01-31T06:11:22Z

catalyst/callbacks/sklearn_model.py

@@ -14,13 +14,15 @@ class SklearnModelCallback(Callback):
    to give predictions on the valid loader.

    Args:
-        feature_key: keys of tensors that should be used as features in the classifier calculations
-        target_key: keys of tensors that should be used as targets in the classifier calculations
+        feature_key: keys of tensors that should be used as features 


[pep8] _{reported by reviewdog 🐶}
W291 trailing whitespace

github-actions · 2022-01-31T06:11:22Z

catalyst/callbacks/sklearn_model.py

-        target_key: keys of tensors that should be used as targets in the classifier calculations
+        feature_key: keys of tensors that should be used as features 
+            for the classifier fit
+        target_key: keys of tensors that should be used as targets 


[pep8] _{reported by reviewdog 🐶}
W291 trailing whitespace

github-actions · 2022-01-31T06:11:22Z

catalyst/callbacks/onnx.py

@@ -16,7 +16,8 @@ class OnnxCallback(Callback):
        input_key: input key from ``runner.batch`` to use for onnx export
        logdir: path to folder for saving
        filename: filename
-        method_name (str, optional): Forward pass method to be converted. Defaults to "forward".
+        method_name (str, optional): Forward pass method to be converted. 


[pep8] _{reported by reviewdog 🐶}
W291 trailing whitespace

github-actions · 2022-01-31T06:11:22Z

catalyst/callbacks/tracing.py

@@ -81,7 +81,8 @@ def __init__(
            input_key: input key from ``runner.batch`` to use for model tracing
            logdir: path to folder for saving
            filename: filename
-            method_name: Model's method name that will be used as entrypoint during tracing
+            method_name: Model's method name 


[pep8] _{reported by reviewdog 🐶}
W291 trailing whitespace

github-actions · 2022-01-31T06:11:24Z

catalyst/callbacks/mixup.py

-            also proxy. We are not interested in them, are we? So, if ``on_train_only``
+        alpha: beta distribution a=b parameters. Must be >=0. 
+            The more alpha closer to zero the less effect of the mixup.
+        mode: mode determines the method of use. Must be in ["replace", "add"]. 


[pep8] _{reported by reviewdog 🐶}
W291 trailing whitespace

github-actions · 2022-01-31T06:11:24Z

catalyst/callbacks/mixup.py

+        alpha: beta distribution a=b parameters. Must be >=0. 
+            The more alpha closer to zero the less effect of the mixup.
+        mode: mode determines the method of use. Must be in ["replace", "add"]. 
+            If "replace" then replaces the batch with a mixed one, 


[pep8] _{reported by reviewdog 🐶}
W291 trailing whitespace

github-actions · 2022-01-31T06:11:24Z

catalyst/callbacks/mixup.py

+        mode: mode determines the method of use. Must be in ["replace", "add"]. 
+            If "replace" then replaces the batch with a mixed one, 
+            while the batch size is not changed.
+            If "add", concatenates mixed examples to the current ones, 


[pep8] _{reported by reviewdog 🐶}
W291 trailing whitespace

github-actions · 2022-01-31T06:11:24Z

catalyst/callbacks/mixup.py

+            while the batch size is not changed.
+            If "add", concatenates mixed examples to the current ones, 
+            the batch size increases by 2 times.
+        on_train_only: apply to train only. 


[pep8] _{reported by reviewdog 🐶}
W291 trailing whitespace

github-actions · 2022-01-31T06:11:24Z

catalyst/callbacks/mixup.py

+            If "add", concatenates mixed examples to the current ones, 
+            the batch size increases by 2 times.
+        on_train_only: apply to train only. 
+            As the mixup use the proxy inputs, the targets are also proxy. 


[pep8] _{reported by reviewdog 🐶}
W291 trailing whitespace

github-actions · 2022-01-31T06:39:43Z

catalyst/runners/runner.py

 class Runner(IRunner):
    """Single-stage deep learning Runner with user-friendly API.

-    Runner supports the logic for deep learning pipeline configuration with pure python code.
+    Runner supports the logic for deep learning pipeline configuration 


[pep8] _{reported by reviewdog 🐶}
W291 trailing whitespace

github-actions · 2022-01-31T06:39:43Z

catalyst/runners/runner.py

@@ -66,7 +54,8 @@ class Runner(IRunner):

        It does not automatically add Criterion, Optimizer or Scheduler callbacks.

-        That means, that you have do optimization step by yourself during ``handle_batch`` method
+        That means, that you have do optimization step by yourself during 


[pep8] _{reported by reviewdog 🐶}
W291 trailing whitespace

github-actions · 2022-01-31T06:39:43Z

catalyst/loggers/neptune.py

-        neptune_run_kwargs: Optional, additional keyword arguments to be passed directly to the
-          `neptune.init() <https://docs.neptune.ai/api-reference/neptune#init>`_ function.
+          (default: SETTINGS.log_epoch_metrics or True).
+        neptune_run_kwargs: Optional, additional keyword arguments 


[pep8] _{reported by reviewdog 🐶}
W291 trailing whitespace

github-actions · 2022-01-31T06:39:43Z

catalyst/loggers/neptune.py

-          `neptune.init() <https://docs.neptune.ai/api-reference/neptune#init>`_ function.
+          (default: SETTINGS.log_epoch_metrics or True).
+        neptune_run_kwargs: Optional, additional keyword arguments 
+          to be passed directly to the 


[pep8] _{reported by reviewdog 🐶}
W291 trailing whitespace

github-actions · 2022-01-31T06:39:43Z

catalyst/loggers/neptune.py

+          (default: SETTINGS.log_epoch_metrics or True).
+        neptune_run_kwargs: Optional, additional keyword arguments 
+          to be passed directly to the 
+          `neptune.init()  <https://docs.neptune.ai/api-reference/neptune#init>`_ 


[pep8] _{reported by reviewdog 🐶}
W291 trailing whitespace

github-actions · 2022-01-31T06:39:43Z

catalyst/loggers/csv.py

@@ -98,21 +98,20 @@ def _log_metrics(self, metrics: Dict[str, float], step: int, loader_key: str):
        log_line_csv = log_line_csv[:-1] + "\n"  # replace last "," with new line
        self.loggers[loader_key].write(log_line_csv)

+    def log_hparams(self, hparams: Dict) -> None:
+        """Logs hyperparameters to the logger."""
+        if scope == "experiment":


[pep8] _{reported by reviewdog 🐶}
F821 undefined name 'scope'

github-actions · 2022-01-31T06:39:44Z

catalyst/loggers/wandb.py

@@ -25,7 +25,8 @@ class WandbLogger(ILogger):
            (default: SETTINGS.log_batch_metrics or False).
        log_epoch_metrics: boolean flag to log epoch metrics
            (default: SETTINGS.log_epoch_metrics or True).
-        kwargs: Optional, additional keyword arguments to be passed directly to the wandb.init
+        kwargs: Optional, 


[pep8] _{reported by reviewdog 🐶}
W291 trailing whitespace

github-actions · 2022-01-31T06:39:44Z

catalyst/loggers/wandb.py

+        artifact = wandb.Artifact(
+            name=self.run.id + "_aritfacts",
+            type="artifact",
+            metadata={"loader_key": loader_key, "scope": scope,},


[pep8] _{reported by reviewdog 🐶}
E231 missing whitespace after ','

github-actions · 2022-01-31T06:39:44Z

catalyst/loggers/console.py

@@ -22,21 +22,20 @@ def __init__(self, log_hparams: bool = False):
        super().__init__(log_batch_metrics=False, log_epoch_metrics=True)
        self._log_hparams = log_hparams

+    def log_hparams(self, hparams: Dict) -> None:
+        """Logs hyperparameters to the console."""
+        if scope == "experiment" and self._log_hparams:


[pep8] _{reported by reviewdog 🐶}
F821 undefined name 'scope'

github-actions · 2022-01-31T06:39:44Z

catalyst/contrib/runners/config.py

@@ -195,7 +195,7 @@ def get_engine(self) -> IEngine:
            engine = REGISTRY.get_from_params(**engine_params)
        else:
            engine = get_available_engine(
-                fp16=self._fp16, ddp=self._ddp, amp=self._amp, apex=self._apex
+                fp16=self._fp16, ddp=self._ddp, fp16=self._amp, apex=self._apex


[pep8] _{reported by reviewdog 🐶}
E999 SyntaxError: keyword argument repeated

github-actions · 2022-01-31T07:10:07Z

catalyst/contrib/utils/torch2.py

@@ -0,0 +1,146 @@
+from typing import Callable, Dict, List, TYPE_CHECKING, Union


[pep8] _{reported by reviewdog 🐶}
F401 'typing.TYPE_CHECKING' imported but unused

github-actions · 2022-01-31T07:10:07Z

catalyst/contrib/utils/torch2.py

+from torch import nn, Tensor
+import torch.backends
+
+from catalyst.settings import SETTINGS


[pep8] _{reported by reviewdog 🐶}
F401 'catalyst.settings.SETTINGS' imported but unused

review-notebook-app · 2022-02-02T06:10:22Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

github-actions · 2022-02-03T05:31:52Z

tests/pipelines/test_contrastive.py

+
+
+# # Torch
+# @mark.skipif(not requirements_satisfied, reason="catalyst[ml] and catalyst[cv] required")


[pep8] _{reported by reviewdog 🐶}
E501 line too long (91 > 89 characters)

github-actions · 2022-02-03T05:31:52Z

tests/pipelines/test_contrastive.py

+
+
+# # Torch
+# @mark.skipif(not requirements_satisfied, reason="catalyst[ml] and catalyst[cv] required")


[pep8] _{reported by reviewdog 🐶}
W505 doc line too long (91 > 89 characters)

github-actions · 2022-02-03T05:31:52Z

tests/catalyst/runners/test_runner.py

    runner = SupervisedRunner()

    runner.evaluate_loader(loader=loader, callbacks=callbacks, model=model)
+
+
+def test_epoch_increasing():


[pep8] _{reported by reviewdog 🐶}
D103 Missing docstring in public function

github-actions · 2022-02-03T05:31:52Z

tests/catalyst/runners/test_runner.py

+
+    # data
+    num_samples, num_features = int(1e4), int(1e1)
+    X = torch.rand(num_samples, num_features)


[pep8] _{reported by reviewdog 🐶}
N806 variable 'X' in function should be lowercase

github-actions · 2022-02-03T05:31:53Z

tests/catalyst/callbacks/test_quantization.py

+#         "train": DataLoader(MNIST(os.getcwd(), train=False), batch_size=32,),
+#         "valid": DataLoader(MNIST(os.getcwd(), train=False), batch_size=32,),
+#     }
+#     model = nn.Sequential(Flatten(), nn.Linear(784, 512), nn.ReLU(), nn.Linear(512, 10))


[pep8] _{reported by reviewdog 🐶}
E501 line too long (90 > 89 characters)

github-actions · 2022-02-03T05:31:53Z

tests/catalyst/callbacks/test_quantization.py

+#         "train": DataLoader(MNIST(os.getcwd(), train=False), batch_size=32,),
+#         "valid": DataLoader(MNIST(os.getcwd(), train=False), batch_size=32,),
+#     }
+#     model = nn.Sequential(Flatten(), nn.Linear(784, 512), nn.ReLU(), nn.Linear(512, 10))


[pep8] _{reported by reviewdog 🐶}
W505 doc line too long (90 > 89 characters)

github-actions · 2022-02-03T05:31:53Z

tests/catalyst/callbacks/test_batch_transform.py

+#         logits = self.model(batch["features"].view(batch["features"].size(0), -1))
+
+#         loss = F.cross_entropy(logits, batch["targets"])
+#         accuracy01, accuracy03 = metrics.accuracy(logits, batch["targets"], topk=(1, 3))


[pep8] _{reported by reviewdog 🐶}
E501 line too long (90 > 89 characters)

github-actions · 2022-02-03T05:31:53Z

tests/catalyst/callbacks/test_batch_transform.py

+#         logits = self.model(batch["features"].view(batch["features"].size(0), -1))
+
+#         loss = F.cross_entropy(logits, batch["targets"])
+#         accuracy01, accuracy03 = metrics.accuracy(logits, batch["targets"], topk=(1, 3))


[pep8] _{reported by reviewdog 🐶}
W505 doc line too long (90 > 89 characters)

github-actions · 2022-02-04T06:22:05Z

catalyst/utils/torch.py

 )
 from catalyst.utils.distributed import get_nn_from_ddp_module
-from catalyst.utils.misc import maybe_recursive_call, merge_dicts
+from catalyst.utils.misc import maybe_recursive_call


[pep8] _{reported by reviewdog 🐶}
F401 'catalyst.utils.misc.maybe_recursive_call' imported but unused

github-actions · 2022-02-04T06:22:06Z

catalyst/callbacks/checkpoint.py

@@ -1,244 +1,22 @@
-from typing import Dict, Iterable, Union
-from collections import OrderedDict
+from typing import Any, Dict, List, Union


[pep8] _{reported by reviewdog 🐶}
F401 'typing.Dict' imported but unused

github-actions · 2022-02-04T06:22:06Z

catalyst/callbacks/checkpoint.py

@@ -1,244 +1,22 @@
-from typing import Dict, Iterable, Union
-from collections import OrderedDict
+from typing import Any, Dict, List, Union


[pep8] _{reported by reviewdog 🐶}
F401 'typing.Union' imported but unused

github-actions · 2022-02-04T06:22:06Z

catalyst/callbacks/checkpoint.py

+from catalyst import utils
+from catalyst.core.callback import Callback, CallbackOrder
+from catalyst.core.runner import IRunner
+from catalyst.utils import (


[pep8] _{reported by reviewdog 🐶}
F401 'catalyst.utils.save_checkpoint' imported but unused

github-actions · 2022-02-04T06:22:06Z

catalyst/callbacks/checkpoint.py

+from catalyst import utils
+from catalyst.core.callback import Callback, CallbackOrder
+from catalyst.core.runner import IRunner
+from catalyst.utils import (


[pep8] _{reported by reviewdog 🐶}
F401 'catalyst.utils.unpack_checkpoint' imported but unused

github-actions · 2022-02-04T06:22:06Z

catalyst/callbacks/checkpoint.py

-                logdir=self.logdir,
-                runner=runner,
-                mapping=self.load_on_stage_start,
+            obj = dict(


[pep8] _{reported by reviewdog 🐶}
C408 Unnecessary dict call - rewrite as a literal.

v22: simplification 2.0

cfe9271

Scitator requested review from bagxi and ditwoo as code owners January 26, 2022 05:36

github-actions bot reviewed Jan 26, 2022

View reviewed changes

Scitator added 2 commits January 26, 2022 08:47

+

02030e6

codestile right margin moved to 89

74f6fb1

github-actions bot reviewed Jan 27, 2022

View reviewed changes

Scitator added 2 commits January 27, 2022 09:09

custom MVP works

ff4efa4

custom MVP works 2.0 - cleanup

c08b947

github-actions bot reviewed Jan 28, 2022

View reviewed changes

Scitator added 2 commits January 28, 2022 09:48

custom SupervisedRunner works

9021ca9

tests dump

b83eb5f

github-actions bot reviewed Jan 28, 2022

View reviewed changes

+

8a56815

github-actions bot reviewed Jan 31, 2022

View reviewed changes

+

5ea70f3

github-actions bot reviewed Jan 31, 2022

View reviewed changes

+

0ae4222

github-actions bot reviewed Jan 31, 2022

View reviewed changes

Scitator added 8 commits February 1, 2022 08:00

+

ff23184

+

68c31b9

+

d2a0d34

+

46b9df4

+

e62302f

+

f25f388

+

35cce67

+

510c3b5

+

8f7cad1

Scitator added 7 commits February 2, 2022 09:39

+

02f6c62

+

e7c95ab

+

b4bae45

+

8b8de22

+

ab8aac2

+

af915f1

+

ac0cf55

github-actions bot reviewed Feb 3, 2022

View reviewed changes

Scitator added 11 commits February 3, 2022 08:34

+

4fcc40c

+

ee1d2c4

+

f28d330

+

912898d

+

9e1aedc

+

c67a6cf

+

4c71247

+

dc85a67

+

8cff630

+

df252b7

+

0dc261d

github-actions bot reviewed Feb 4, 2022

View reviewed changes

Scitator added 5 commits February 4, 2022 09:32

+

032da4d

+

85ba843

+

0268296

+

3f08df7

+

652c705

ditwoo approved these changes Feb 4, 2022

View reviewed changes

Scitator merged commit fccfb60 into master Feb 4, 2022

mergify bot deleted the dev22 branch February 4, 2022 07:27


		from catalyst.typing import Criterion, Device, Model, Optimizer, Scheduler
		class IEngine(Accelerator):

		@@ -0,0 +1,146 @@
		from typing import Callable, Dict, List, TYPE_CHECKING, Union



		# # Torch
		# @mark.skipif(not requirements_satisfied, reason="catalyst[ml] and catalyst[cv] required")

v22: simplification 2.0 #1395

v22: simplification 2.0 #1395

Conversation

Scitator commented Jan 26, 2022 • edited Loading

Pull Request FAQ

Description

Related Issue

Type of Change

PR review

Checklist

pep8speaks commented Jan 26, 2022 • edited Loading

Comment last updated at 2022-01-26 05:47:43 UTC

github-actions bot Jan 26, 2022

Choose a reason for hiding this comment

github-actions bot Jan 26, 2022

Choose a reason for hiding this comment

github-actions bot Jan 26, 2022

Choose a reason for hiding this comment

github-actions bot Jan 26, 2022

Choose a reason for hiding this comment

github-actions bot Jan 26, 2022

Choose a reason for hiding this comment

github-actions bot Jan 26, 2022

Choose a reason for hiding this comment

github-actions bot Jan 26, 2022

Choose a reason for hiding this comment

github-actions bot Jan 26, 2022

Choose a reason for hiding this comment

github-actions bot Jan 26, 2022

Choose a reason for hiding this comment

github-actions bot Jan 26, 2022

Choose a reason for hiding this comment

github-actions bot Jan 27, 2022

Choose a reason for hiding this comment

github-actions bot Jan 28, 2022

Choose a reason for hiding this comment

github-actions bot Jan 28, 2022

Choose a reason for hiding this comment

github-actions bot Jan 28, 2022

Choose a reason for hiding this comment

github-actions bot Jan 28, 2022

Choose a reason for hiding this comment

github-actions bot Jan 28, 2022

Choose a reason for hiding this comment

github-actions bot Jan 28, 2022

Choose a reason for hiding this comment

github-actions bot Jan 28, 2022

Choose a reason for hiding this comment

github-actions bot Jan 28, 2022

Choose a reason for hiding this comment

github-actions bot Jan 28, 2022

Choose a reason for hiding this comment

github-actions bot Jan 28, 2022

Choose a reason for hiding this comment

github-actions bot Jan 28, 2022

Choose a reason for hiding this comment

github-actions bot Jan 31, 2022

Choose a reason for hiding this comment

github-actions bot Jan 31, 2022

Choose a reason for hiding this comment

github-actions bot Jan 31, 2022

Choose a reason for hiding this comment

github-actions bot Jan 31, 2022

Choose a reason for hiding this comment

github-actions bot Jan 31, 2022

Choose a reason for hiding this comment

github-actions bot Jan 31, 2022

Choose a reason for hiding this comment

github-actions bot Jan 31, 2022

Choose a reason for hiding this comment

github-actions bot Jan 31, 2022

Choose a reason for hiding this comment

github-actions bot Jan 31, 2022

Choose a reason for hiding this comment

github-actions bot Jan 31, 2022

Choose a reason for hiding this comment

github-actions bot Jan 31, 2022

Choose a reason for hiding this comment

github-actions bot Jan 31, 2022

Choose a reason for hiding this comment

Scitator commented Jan 26, 2022 •

edited

Loading

pep8speaks commented Jan 26, 2022 •

edited

Loading