Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for T11 #13

Closed
dmitriim opened this issue May 11, 2018 · 5 comments
Closed

Support for T11 #13

dmitriim opened this issue May 11, 2018 · 5 comments

Comments

@dmitriim
Copy link
Member

While testing the plugin in T11 I got the following errors/warnings:

The function ojt_print_recent_activity have being deprected since totara 11 line 234 of /blocks/recent_activity/block_recent_activity.php: call to debugging() line 74 of /blocks/recent_activity/block_recent_activity.php: call to block_recent_activity->get_modules_recent_activity() line 288 of /blocks/moodleblock.class.php: call to block_recent_activity->get_content() line 230 of /blocks/moodleblock.class.php: call to block_base->formatted_contents() line 1180 of /lib/blocklib.php: call to block_base->get_content_for_output() line 1235 of /lib/blocklib.php: call to block_manager->create_block_contents() line 354 of /lib/blocklib.php: call to block_manager->ensure_content_created() line 38 of /theme/alh/layout/default.php: call to block_manager->region_has_content() line 844 of /lib/outputrenderers.php: call to include() line 774 of /lib/outputrenderers.php: call to core_renderer->render_page_layout() line 252 of /course/view.php: call to core_renderer->header()

@euven
Copy link
Member

euven commented May 14, 2018

Hi @dmitriim

I did remove this function already - see b9ec459

Could you test on T11 with the master branch and let me know if you encounter any issues?

I'll leave this issue open for now ;)

Thanks!
Eugene.

@dmitriim
Copy link
Member Author

Hi @bynare ! Sorry was using v10 branch. I was confused by WIKI https://github.com/catalyst/totara-mod-ojt/wiki Was thinking a branch should match a version. Maybe we should remove this section from the wiki?

image

@euven
Copy link
Member

euven commented May 14, 2018

I agree @dmitriim - removed that bit, as it can become stale too easily ;)

@euven
Copy link
Member

euven commented May 14, 2018

@dmitriim can you confirm that everything works as expected on Totara 11? If it does, I'll create a new branch for Totara 11.

@dmitriim
Copy link
Member Author

@bynare looks like it works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants