Add nice error messages for unsupported && and || #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1480 +/- ##
=======================================
Coverage 80.39% 80.39%
=======================================
Files 121 121
Lines 3426 3426
=======================================
Hits 2754 2754
Misses 672 672 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1480 +/- ##
=======================================
Coverage 80.39% 80.39%
=======================================
Files 121 121
Lines 3426 3426
=======================================
Hits 2754 2754
Misses 672 672 |
As explained in issue #1273, `operator&&` and `operator||` should give a proper compile time error on use instead of the compiler complaining about them not being defined. This commit adds an `always_false` type in `catch_meta.hpp` used for implementing a nice `static_assert` for both of the abovementioned operators. Closes #1273
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As explained in issue #1273,
operator&&andoperator||should givea proper compile time error on use instead of the compiler complaining
about them not being defined. This PR adds an
always_falsetype incatch_meta.hppused for implementing a nicestatic_assertfor bothof the abovementioned operators.
GitHub Issues
Closes #1273