Specify PHP version with Composer #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When looking through the codebase, I often wondered what PHP features were fair game to use, such as `http_response_code()` instead of the easier-to-mess-up `header('HTTP/…')`. [Specifying PHP’s minimum version in `composer.json`](https://mikemadison.net/blog/2020/11/17/configuring-php-version-with-composer) helps with questions like that, and should produce friendlier and easier-to-understand errors if the code is run with an older PHP runtime.
I set the version to the minimum that [Guzzle 7.4](https://packagist.org/packages/guzzlehttp/guzzle#7.4.0) requires, since that looked like a safe bet.
jefflembeck
reviewed
Mar 7, 2022
Co-authored-by: Jeff Lembeck <jlembeck@gmail.com>
jefflembeck
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking through the codebase, I often wondered what PHP features were fair game to use, such as
http_response_code()instead of the easier-to-mess-upheader('HTTP/…'). Specifying PHP’s minimum version incomposer.jsonhelps with questions like that, and should produce friendlier and easier-to-understand errors if the code is run with an older PHP runtime.I set the version to the minimum that Guzzle 7.4 requires, since that looked like a safe bet.