fix(account): style plan selector #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please forgive me for the CSS crimes I have committed today. First: Those selectors. You see. We're replicating UX that would normally be done with JavaScript and we're doing it _without javascript_ so I feel like this is something that can be overlooked. Second: We should find a fun and clever way to make this something a little more reusable because we have this pattern a few times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please forgive me for the CSS crimes I have committed today.
First: Those selectors. You see. We're replicating UX that would
normally be done with JavaScript and we're doing it without javascript
so I feel like this is something that can be overlooked.
Second: We should find a fun and clever way to make this something a
little more reusable because we have this pattern a few times