feat(signup): Error handling #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefflembeck
force-pushed
the
signup-exists-fix
branch
from
57b0d94
to
591d7f5
Compare
This covers a few different kind of error. If the user manages to put in incorrect or bad data, this will show. Also, if the user uses an email that's already been used, an error will show. This leads us to an interesting place where we need to think out how we want to handle global (banner) vs local (in the form itself?) errors and how we make those easy enough to get into
The notification banner wasn't quite noticeable. You need something that screams a little. Also this commit has some cleanup in CPSignupClient where the libs being referenced were no longer in use
jefflembeck
force-pushed
the
signup-exists-fix
branch
from
591d7f5
to
9b82009
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers a few different kinds of error. If the user manages to put in
incorrect or bad data, this will show. Also, if the user uses an email
that's already been used, an error will show.
This leads us to an interesting place where we need to think out how we
want to handle global (banner) vs local (in the form itself?) errors and
how we make those easy enough to get into.
For global, this PR addresses the top bar by making it a tint of red with a dark text. This catches the eye quite a bit better than our normal alert banner.
(merge #1848 first)