Added ADR #3 re: jQuery #2106
Added ADR #3 re: jQuery #2106
Conversation
| ## 🎬 Consequences | ||
| - Remove XSS vulnerability | ||
| - Lighter page | ||
|
|
There was a problem hiding this comment.
Is the full list of dependencies just dialogs and tabs right now?
There was a problem hiding this comment.
I think there's some stuff in www/site.js
I saw a $.ajax
There was a problem hiding this comment.
Here's a list of what I see in there:
- drag and resizing (not sure where this is used)
- viewport offsets
- getting OS scrollbar width
- displaying local time
- tooltips
- scroll handling
- editting test labels
|
|
||
|
|
||
| ## 🤔 Decision | ||
| Remove jQuery and jQuery UI dependencies. Dialogs and tabs can be implemented in CSS with a sprinkle JavaScript. |
There was a problem hiding this comment.
Feel like we can ditch the "dialogs and tabs" bit and expand a bit.
Something like....
"We can replace existing jQuery dependencies, and build new components, by focusing on a strong foundation of markup and CSS, with JavaScript sprinkled in as necessary for enhancement."
There was a problem hiding this comment.
Also, maybe we should make it explicit for anyone later that we intend on using vanilla JS at the moment.
Again...
"We will be using vanilla JavaScript, rather than immediately switching to another framework, to keep the performance overhead to a minimum."
No description provided.