Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support hyprcursor #23

Merged
merged 8 commits into from
May 31, 2024
Merged

Conversation

trowgundam
Copy link
Contributor

I've added support for hyprcursor.

This is a re-implementation of #18 based on the recent reworking of the repository. It was easier to just re-implement things than trying to rebase and fixing things due to the change from make to just.

@sgoudham sgoudham linked an issue May 28, 2024 that may be closed by this pull request
@sgoudham sgoudham self-requested a review May 28, 2024 22:24
README.md Outdated Show resolved Hide resolved
build Show resolved Hide resolved
build Outdated Show resolved Hide resolved
@sgoudham
Copy link
Contributor

sgoudham commented May 31, 2024

Hi @trowgundam,

I've set up a CI/CD workflow which builds all the themes and outputs them as artifacts. I've refactored some of the script and the build command to be more explicit, now using just all and just all_with_hyprcursor for verbosity. Accents is now a default parameter so you can do just build mocha and just build mocha blue etc

Could you please confirm the assets inside of the artifacts linked below work as intended on your system?
https://github.com/catppuccin/cursors/actions/runs/9325025650/artifacts/1557799918

@trowgundam
Copy link
Contributor Author

Hi @sgoudham,

It looks good and works for me. There were some weird spaces before the version line in the manifest, but your one commit fixed that when I built it myself. The only other weird thing is the version is surrounded by quotes and has some sort of, what I'm guessing is, a comment, but it didn't stop Hyprland from loading the theme. So it's probably not a big deal. I don't think most of that metadata is actually used for anything outside of the name anyways.

@sgoudham
Copy link
Contributor

sgoudham commented May 31, 2024

The only other weird thing is the version is surrounded by quotes and has some sort of, what I'm guessing is, a comment, but it didn't stop Hyprland from loading the theme.

Yeah I took a gamble on that one, instead of using the git version, I think it'd make sense to use the release please version that the theme will be released under (the comment allows for release-please to automatically update the version on PRs) but maybe it's better to keep the git sha? I'm not too fussed about that one.

@trowgundam
Copy link
Contributor Author

Hyprland could use the theme just fine. I had originally tried to figure out a good way to grab a version when I first wrote the script, so it's actually perfect like that. As long as the theme works, it's good in my book.

@sgoudham
Copy link
Contributor

Great! I'm happy to approve once you add yourself to the AUTHORS file! :D

@trowgundam
Copy link
Contributor Author

Done

@sgoudham sgoudham merged commit 28cb6d2 into catppuccin:main May 31, 2024
1 check passed
This was referenced May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Hyprcursor support
2 participants