Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Helm #143

Open
lunacd opened this issue Mar 30, 2024 · 3 comments
Open

Add support for Helm #143

lunacd opened this issue Mar 30, 2024 · 3 comments
Labels
enhancement New feature or request new faces

Comments

@lunacd
Copy link

lunacd commented Mar 30, 2024

#125 touches upon this, and we already have an unimplemented section here:

emacs/catppuccin-theme.el

Lines 628 to 657 in 3d93aba

;; TODO: Theme helm
(helm-bookmark-w3m :foreground ,undef)
(helm-buffer-not-saved :foreground ,undef)
(helm-buffer-process :foreground ,undef)
(helm-buffer-saved-out :foreground ,undef)
(helm-buffer-size :foreground ,undef)
(helm-candidate-number :foreground ,undef)
(helm-ff-directory :foreground ,undef)
(helm-ff-dotted-directory :foreground ,undef)
(helm-ff-executable :foreground ,undef)
(helm-ff-file :foreground ,undef)
(helm-ff-invalid-symlink :foreground ,undef)
(helm-ff-prefix :foreground ,undef)
(helm-ff-symlink :foreground ,undef)
(helm-grep-cmd-line :foreground ,undef)
(helm-grep-file :foreground ,undef)
(helm-grep-finish :foreground ,undef)
(helm-grep-lineno :foreground ,undef)
(helm-grep-match :inherit match)
(helm-grep-running :foreground ,undef)
(helm-header :foreground ,undef)
(helm-moccur-buffer :foreground ,undef)
(helm-selection :underline nil)
(helm-selection-line)
(helm-separator :foreground ,undef)
(helm-source-go-package-godoc-description :foreground ,undef)
(helm-source-header :foreground ,undef)
(helm-time-zone-current :foreground ,undef)
(helm-time-zone-home :foreground ,undef)
(helm-visible-mark :foreground ,undef)

It'd be nice to have helm supported. And if someone can point me to how I could approach this, I can take a stab at it as well.

@NamesCode
Copy link
Member

#125 touches upon this, and we already have an unimplemented section here:

emacs/catppuccin-theme.el

Lines 628 to 657 in 3d93aba

;; TODO: Theme helm
(helm-bookmark-w3m :foreground ,undef)
(helm-buffer-not-saved :foreground ,undef)
(helm-buffer-process :foreground ,undef)
(helm-buffer-saved-out :foreground ,undef)
(helm-buffer-size :foreground ,undef)
(helm-candidate-number :foreground ,undef)
(helm-ff-directory :foreground ,undef)
(helm-ff-dotted-directory :foreground ,undef)
(helm-ff-executable :foreground ,undef)
(helm-ff-file :foreground ,undef)
(helm-ff-invalid-symlink :foreground ,undef)
(helm-ff-prefix :foreground ,undef)
(helm-ff-symlink :foreground ,undef)
(helm-grep-cmd-line :foreground ,undef)
(helm-grep-file :foreground ,undef)
(helm-grep-finish :foreground ,undef)
(helm-grep-lineno :foreground ,undef)
(helm-grep-match :inherit match)
(helm-grep-running :foreground ,undef)
(helm-header :foreground ,undef)
(helm-moccur-buffer :foreground ,undef)
(helm-selection :underline nil)
(helm-selection-line)
(helm-separator :foreground ,undef)
(helm-source-go-package-godoc-description :foreground ,undef)
(helm-source-header :foreground ,undef)
(helm-time-zone-current :foreground ,undef)
(helm-time-zone-home :foreground ,undef)
(helm-visible-mark :foreground ,undef)

It'd be nice to have helm supported. And if someone can point me to how I could approach this, I can take a stab at it as well.

Heyo! if you want to take a go at it i'm free to have a call on discord at any point to explain things, otherwise I can get around to doing this at some point

@lunacd
Copy link
Author

lunacd commented Jun 10, 2024

Heyo! if you want to take a go at it i'm free to have a call on discord at any point to explain things, otherwise I can get around to doing this at some point

Thanks for reaching out! Unfortunately or fortunately, I have been exclusively using Ivy with issues lol. Maybe I'll take a stab at this when I feel the need to switch to Helm :)

@NamesCode
Copy link
Member

All good! ^^

@sgoudham sgoudham changed the title Helm support Add support for Helm Aug 5, 2024
@sgoudham sgoudham added the enhancement New feature or request label Aug 5, 2024
@jtbx jtbx added the new faces label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new faces
Projects
None yet
Development

No branches or pull requests

4 participants