-
-
Notifications
You must be signed in to change notification settings - Fork 54
[v1.0.0-rc3] black tweak differences between pre-1.x and 1.x #212
Comments
gtk-4.0/gtk-dark.css --- 172/174 --- Text (346 CSS parse errors, exceeded DFT_PARSE_ERROR_LIMIT)
8349 @define-color wm_title #FFFFFF; 8348 @define-color wm_title #FFFFFF;
8350 @define-color wm_unfocused_title rgba(255, 255, 255, 0.7); 8349 @define-color wm_unfocused_title rgba(255, 255, 255, 0.7);
8351 @define-color wm_highlight rgba(255, 255, 255, 0.1); 8350 @define-color wm_highlight rgba(255, 255, 255, 0.1);
8352 @define-color wm_border rgba(26, 33, 24, 0.94902); 8351 @define-color wm_border #0a0a0e;
8353 @define-color wm_bg #11111b; 8352 @define-color wm_bg #313244;
8354 @define-color wm_unfocused_bg #CAFEBABE; 8353 @define-color wm_unfocused_bg #313244;
8355 @define-color wm_button_icon white; 8354 @define-color wm_button_icon white;
8356 @define-color wm_button_close_hover_bg #f38ba8; 8355 @define-color wm_button_close_hover_bg #f38ba8;
8357 @define-color wm_button_close_active_bg #ed547e; 8356 @define-color wm_button_close_active_bg #ed547e;
gtk-4.0/gtk-dark.css --- 173/174 --- Text (346 CSS parse errors, exceeded DFT_PARSE_ERROR_LIMIT)
8361 @define-color wm_button_min_active_bg #f5cd76; 8360 @define-color wm_button_min_active_bg #f5cd76;
8362 /* 8361 /*
8363 FIXME this is really an API */ 8362 FIXME this is really an API */
8364 @define-color content_view_bg #CAFEBABE; 8363 @define-color content_view_bg #313244;
8365 @define-color placeholder_text_color rgba(244, 255, 241, 0.923529); 8364 @define-color placeholder_text_color #c1c2c7;
8366 /* Very contrasty background for text views (@theme_text_color foregroun 8365 /* Very contrasty background for text views (@theme_text_color foregroun
.... d) */ .... d) */
8367 @define-color text_view_bg #CAFEBABE; 8366 @define-color text_view_bg #313244;
8368 @define-color budgie_tasklist_indicator_color rgba(255, 255, 255, 0.3); 8367 @define-color budgie_tasklist_indicator_color rgba(255, 255, 255, 0.3);
8369 @define-color budgie_tasklist_indicator_color_active #cba6f7; 8368 @define-color budgie_tasklist_indicator_color_active #cba6f7;
8370 @define-color budgie_tasklist_indicator_color_active_window #6e5a85; 8369 @define-color budgie_tasklist_indicator_color_active_window #7b679b;
8371 @define-color budgie_tasklist_indicator_color_attention #f9e2af; 8370 @define-color budgie_tasklist_indicator_color_attention #f9e2af;
8372 @define-color STRAWBERRY_100 #FF9262; 8371 @define-color STRAWBERRY_100 #FF9262;
8373 @define-color STRAWBERRY_300 #FF793E; 8372 @define-color STRAWBERRY_300 #FF793E;
gtk-4.0/gtk-dark.css --- 174/174 --- Text (346 CSS parse errors, exceeded DFT_PARSE_ERROR_LIMIT)
8482 @define-color error_bg_color #f38ba8; 8481 @define-color error_bg_color #f38ba8;
8483 @define-color error_fg_color rgba(0, 0, 0, 0.87); 8482 @define-color error_fg_color rgba(0, 0, 0, 0.87);
8484 @define-color error_color #f38ba8; 8483 @define-color error_color #f38ba8;
8485 @define-color window_bg_color #CAFEBABE; 8484 @define-color window_bg_color #313244;
8486 @define-color window_fg_color rgba(0, 0, 0, 0.87); 8485 @define-color window_fg_color #FFFFFF;
8487 @define-color view_bg_color #CAFEBABE; 8486 @define-color view_bg_color #313244;
8488 @define-color view_fg_color rgba(0, 0, 0, 0.87); 8487 @define-color view_fg_color #FFFFFF;
8489 @define-color headerbar_bg_color #11111b; 8488 @define-color headerbar_bg_color #313244;
8490 @define-color headerbar_fg_color #FFFFFF; 8489 @define-color headerbar_fg_color #FFFFFF;
8491 @define-color headerbar_border_color rgba(255, 255, 255, 0.12); 8490 @define-color headerbar_border_color rgba(255, 255, 255, 0.12);
8492 @define-color headerbar_backdrop_color #CAFEBABE; 8491 @define-color headerbar_backdrop_color #313244;
8493 @define-color headerbar_shade_color rgba(255, 255, 255, 0.12); 8492 @define-color headerbar_shade_color rgba(255, 255, 255, 0.12);
8494 @define-color card_bg_color #CAFEBABE; 8493 @define-color card_bg_color #313244;
8495 @define-color card_fg_color rgba(0, 0, 0, 0.87); 8494 @define-color card_fg_color #FFFFFF;
8496 @define-color card_shade_color rgba(255, 255, 255, 0.12); 8495 @define-color card_shade_color rgba(255, 255, 255, 0.12);
8497 @define-color dialog_bg_color #11111b; 8496 @define-color dialog_bg_color #313244;
8498 @define-color dialog_fg_color rgba(0, 0, 0, 0.87); 8497 @define-color dialog_fg_color #FFFFFF;
8499 @define-color popover_bg_color #CAFEBABE; 8498 @define-color popover_bg_color #313244;
8500 @define-color popover_fg_color rgba(0, 0, 0, 0.87); 8499 @define-color popover_fg_color #FFFFFF;
8501 @define-color shade_color rgba(255, 255, 255, 0.12); 8500 @define-color shade_color rgba(255, 255, 255, 0.12);
8502 @define-color scrollbar_outline_color rgba(255, 255, 255, 0.12); 8501 @define-color scrollbar_outline_color rgba(255, 255, 255, 0.12); As a test, I added in some garbage (CAFEBABE) into the condition where 'blackness' is applied (colors.scss background function), and as you can see it is being applied to the theme throughout. There is undoubtedly going to be changes in the theme, basically because the old build system ran a find and replace across all of colloid looking for hex codes to replace. The new system properly integrates with colloid to give it full control over the palette. My understanding is that you haven't tested this visually, only looked at the diff? If so, I'd appreciate some visual confirmation this is a bug, because diff-only analysis will not work when jumping from 0.x to 1.x 👍 As for your queries about color clipping, it is a colloid limitation. The old system had this too. We cannot map from our palette to colloid's 1:1, and have not yet retrofit colloid to support this. Therefor we approximate a best-effort color from colloid which maps into our palette. (The reason you see sky in the css is likely because we specify it specifically for links in the theme, as colloid allows us to put a different color in there) |
@nullishamy it is visually different (blackness). I'll take some screenshots when I get back to a computer. |
@nullishamy here is what I had been using first, then rc3 with and without the blackness tweak. edit: window bars are themed using hyprland catppuccin and not gtk. 87a5f92 - blackness |
Color codes for the dark empty regions in each screenshot. $ hyprpicker # my 87a5f92 blackness
#010101 # pre 1.x blackness tweak not from palette
$ hyprpicker # my rc3 blackness
#181926 # Macchiato Crust
$ hyprpicker # my rc3 no blackness
#363A4F # Macchiato Surface0
$ hyprpicker # nullishamy rc3 blackness
#11111B # Mocha Crust
$ hyprpicker # nullishamy rc3 no blackness
#313244 # Mocha Surface0 |
I'll switch to mocha for now as it is the darkest of the 4 palettes. The colloid limitation makes sense. I also understand if this is a won't fix situation for blackness. If there comes a time I really really want it and this is closed as a won't fix, I can work on a true-black/amoled-black tweak PR when I find some time. I'll leave it up to the maintainers if they want to close this or not. Appreciate the effort and for looking into this! |
This comment was marked as off-topic.
This comment was marked as off-topic.
If there's other changes to report as bugs, let's make another issue for it, keep things organised. @txtsd |
@higherorderfunctor This is really helpful, thanks 🙏. Kind of expected, yeah, that the old system put random colours in there... As I thought, this area of the old script handles setting up the palette, as opposed to this template file in the new one. I don't believe those super dark shades of gray are used anywhere else except the darkness mode, so we could certainly work on a palette change that makes it 'more true' to the old system? From what you've posted, the new system is actually using the palette correctly instead of these off palette colours, which is generally much better, though we do understand the desire to keep things looking similar to how they were, of course 👍 What do you think about adding a tweak that configures the build to use the old palette (in this case, just the darks)? This could be easily plugged into the build system, and if we want to try it out I'm more than happy to open a PR to get some test builds up! |
|
@nullishamy I love it! The small calendar is a little darker, but that is probably because I switched to mocha. If this gets merged, which I hope it does, nix will need to have its options updated when they update to 1.x. I had to hard code oled into my build command. |
Hello again I released rc4 (https://github.com/catppuccin/gtk/releases/tag/v1.0.0-rc4), which changes the tweak back to |
Ill test in the next hour or so. Thanks! |
The black tweak looks good to me @nullishamy building from main. Thanks again! |
Is there an existing issue outlining your problem?
Describe the bug.
Comparing 0c3e881 versus 87a5f92 (rc3), it doesn't appear the black tweak is getting applied.
Also, not sure if this is just a limitation with the new build system, a design choice going forward (https://github.com/catppuccin/gtk/blob/main/build.py#L247), or if it is unintentional and should be fixed, but in my spot testing it looks like Sky is mapped to mostly Teal.
I'm using a custom nix overlay to install, but the build log looks like it should from what I can tell by showing which tweaks I have and the theme color.
I've also included a full diff for the gtk-4.0.css. I dont expect a 100% match, but figured these two items standout.
Build log
gtk-4.0.css full diff
Attach screenshots.
No response
How did you install the theme?
From source (Python script)
If using GTK4, have you symlinked the "gtk-4.0" folder?
gtk-4.0
folder.What GNOME version are you seeing the bug on?
N/A
Any additional comments?
I'm using https://github.com/Aylur/ags not gnome-shell, but the differences are visible in the theme files.
The text was updated successfully, but these errors were encountered: