Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu hover background color clashes with text #18

Closed
hydroEng opened this issue Nov 24, 2022 · 3 comments
Closed

Menu hover background color clashes with text #18

hydroEng opened this issue Nov 24, 2022 · 3 comments

Comments

@hydroEng
Copy link

hydroEng commented Nov 24, 2022

Hi,

Thanks for the nice theme.

There are some contrast issues when I hover my cursor over KDE menus (without clicking anything). This issue goes away if I click a menu item first and then hover my cursor over the other menu items.

See pics (note - flameshot doesn't capture my cursor):

Dolphin:

image

LO Writer:

image

@Sourcastic
Copy link
Member

Hi, thanks for the issue.

We can fix this by making the hover colour something like, say, surface0 or perhaps overlay0. A problem I've noticed though is that if you change your accent colour, it changes the hover colour as well and that is unfixable unless you go through and change every instance of flamingo manually. But being readable, at least in the base theme, is good.

So, I guess, changing it to a different colour would fix your issue?

P.S it's mostly personal preference, but KDE's own screenshot tool (spectacle) can capture your cursor.

@Sourcastic
Copy link
Member

Sourcastic commented Nov 24, 2022

Hi, I've pushed a change that changed the hover colour to surface0. Do tell me how you like it, and text should be a little more readable now.
Here's a screenshot:
image

Do try it out and let me know what you think, so we can close the issue!

@hydroEng
Copy link
Author

Thanks, that looks much better! Really appreciate your hard work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants