Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nvim-surround): add integration #733

Merged
merged 3 commits into from
Jul 18, 2024
Merged

feat(nvim-surround): add integration #733

merged 3 commits into from
Jul 18, 2024

Conversation

emxxjnm
Copy link
Contributor

@emxxjnm emxxjnm commented Jul 18, 2024

This is to distinguish the document highlight of LSP. NvimSurroundHighlight is linked to Visual by default, so they both have the same background color 'surface1'.

NOTE: Sometimes, LspReferenceXxxx (document highlight) color may override the NvimSurroundHighlight. I have no idea how to fix that, need somebody to help.

Snapshot:
WeChatWorkScreenshot_c90c974f-32ca-4f8c-958f-0135cd8558b7

WeChatWorkScreenshot_29a27585-7ad9-42af-9998-0eeec79ed7b3 WeChatWorkScreenshot_62eaf123-6c4c-40b7-a1b3-fb6f1d673071

README.md Outdated Show resolved Hide resolved
@vollowx
Copy link
Collaborator

vollowx commented Jul 18, 2024

NOTE: Sometimes, LspReferenceXxxx (document highlight) color may override the NvimSurroundHighlight. I have no idea how to fix that, need somebody to help.

Could you please check if that happens with other colorschemes? I guess this is not related to catppuccin.nvim.

@emxxjnm
Copy link
Contributor Author

emxxjnm commented Jul 18, 2024

NOTE: Sometimes, LspReferenceXxxx (document highlight) color may override the NvimSurroundHighlight. I have no idea how to fix that, need somebody to help.

Could you please check if that happens with other colorschemes? I guess this is not related to catppuccin.nvim.

Yep, this is not an issue of catppuccin

@vollowx
Copy link
Collaborator

vollowx commented Jul 18, 2024

I guess you've modified something unrelated in the doc - nvim-tree 😉 @emxxjnm

BTW as that's not a catppuccin issue, maybe you can report that to nvim-surround, and we can merge after the document is corrected.

@emxxjnm
Copy link
Contributor Author

emxxjnm commented Jul 18, 2024

sry, already amended😵

@vollowx vollowx merged commit 3f16c6d into catppuccin:main Jul 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants