Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for spm #200

Merged
merged 9 commits into from
Oct 14, 2019
Merged

Add support for spm #200

merged 9 commits into from
Oct 14, 2019

Conversation

akarsh
Copy link
Collaborator

@akarsh akarsh commented Oct 8, 2019 •
edited by brototyp
Loading

This adds SPM support for the Cauli Framework.

Fixes #199

@akarsh
update rake file with test for swift build
9569237 
- add test to build a swift package from Cauliframework
@akarsh
Add Package.swift
aaf73da 
Contains description about the package
@akarsh
Refactor the comments in the file to swift tools version
b8307e2 
Swift build did not recognise the tools version earlier.
@akarsh akarsh mentioned this pull request Oct 8, 2019
Closed
4 tasks
brototyp-bot
brototyp-bot reviewed Oct 8, 2019
View reviewed changes
Package.swift

import PackageDescription

let package = Package(
Copy link

@brototyp-bot brototyp-bot Oct 8, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Top-level declarations should specify Access Control Level keywords explicitly.

brototyp
brototyp reviewed Oct 9, 2019
View reviewed changes
Rakefile Show resolved Hide resolved
@akarsh
Copy link
Collaborator Author

akarsh commented Oct 9, 2019 •
edited
Loading

swift build is sufficient or if we need to define the sdk and target.

it is not sufficient anymore. I saw the error from CI - https://travis-ci.org/cauliframework/cauli/builds/595614756#L1985 which is the same as I mentioned before #199 (comment) we need to add some configuration to define the target and sdk path

@brototyp
Copy link
Member

swift build is sufficient or if we need to define the sdk and target.

it is not sufficient anymore. I saw the error from CI - https://travis-ci.org/cauliframework/cauli/builds/595614756#L1985 which is the same as I mentioned before #199 (comment) we need to add some configuration to define the target and sdk path

Yeah. I also had a look at it. I thought we can just set the Platform in the Package.swift like this (which we should) but that doesn't work either.

    name: "Cauliframework",
    platforms: [
        .iOS(.v8)
    ],

Do you want to try the solution you found before?

@akarsh
Refactor swift build command
7fc40a0 
- swift build command is refactored and additional parameters are added which are specific to iOS.
@akarsh
Add backslash to escape double quotes and backtick
b6f93ba
@akarsh
Copy link
Collaborator Author

akarsh commented Oct 10, 2019

In this commit b6f93ba I tried with my solution to the swift build it works now.

@brototyp
Copy link
Member

Super awesome! Great work. What do you think about either tweaking the Package.swift to comply with the switflint rules or exclude it from being checked by swiftlint?
Just so we get rid of the warnings here. I think once we got that, we can merge this.

@akarsh
Add exception for Package.swift in Swiftlint
5269f89 
- Add empty space for end of file.
@akarsh
Copy link
Collaborator Author

akarsh commented Oct 11, 2019

Super awesome! Great work. What do you think about either tweaking the Package.swift to comply with the switflint rules or exclude it from being checked by swiftlint?
Just so we get rid of the warnings here. I think once we got that, we can merge this.

I added Package.swift in exclude section of swiftlint in this commit
5269f89

@brototyp
Copy link
Member

Really nice. I noticed one more thing. In your ticket you wrote this:

Add a section about swift package manager (spm) in brief similar to the pods to README.md

I think that's actually a really good idea. Do you still want to do that?

@akarsh
Add section Swift Package Manager
cf7aad5 
- Add dependency code with cauli release version
@akarsh
Copy link
Collaborator Author

akarsh commented Oct 11, 2019

I agree with you. I was waiting for the approval to the code before adding the section to the README.md file. This commit cf7aad5 updates the README.md file.

@brototyp
Copy link
Member

Really nice. Well done! Thanks for your work!

@brototyp brototyp merged commit 8738196 into cauliframework:develop Oct 14, 2019
@brototyp
Copy link
Member

Hey @akarsh, congratulations to your first merged pull request. Cauli is now your project too. I just invited you as a team member with write permission. We are exited to have you!

@akarsh
Copy link
Collaborator Author

akarsh commented Oct 14, 2019

Thank you @brototyp
I am happy to be part of the project.

Shukuyen pushed a commit that referenced this pull request Apr 6, 2020
@akarsh @Shukuyen
Add support for spm (#200)
da9d77e 
* update rake file with test for swift build

- add test to build a swift package from Cauliframework

* Add Package.swift

Contains description about the package

* Refactor the comments in the file to swift tools version

Swift build did not recognise the tools version earlier.

* refactor the spm task into package manager namespace

* Downgrade  swift tools version from 5.1 to 5.0

* Refactor swift build command

- swift build command is refactored and additional parameters are added which are specific to iOS.

* Add backslash to escape double quotes and backtick

* Add exception for Package.swift in Swiftlint

- Add empty space for end of file.

* Add section Swift Package Manager
- Add dependency code with cauli release version
Shukuyen added a commit that referenced this pull request Apr 7, 2020
@Shukuyen @brototyp @akarsh
Add an optional description parameter to the Floret protocol (#195)
8efc7d2 
* #176 added description to Floret protocol

* #176 added sample descriptions to some florets

* #176 expose floret description in CauliViewController table view

* Updated Quick, Nimble, SwiftLint and OHHTTPStubs (#194)

* Updated Quick, Nimble, SwiftLint and OHHTTPStubs

* Updated travis to use xcode10.2

* Rakefile cleanup

* Workaround

* Updated to Swift 5 (#201)

* Add support for spm (#200)

* update rake file with test for swift build

- add test to build a swift package from Cauliframework

* Add Package.swift

Contains description about the package

* Refactor the comments in the file to swift tools version

Swift build did not recognise the tools version earlier.

* refactor the spm task into package manager namespace

* Downgrade  swift tools version from 5.1 to 5.0

* Refactor swift build command

- swift build command is refactored and additional parameters are added which are specific to iOS.

* Add backslash to escape double quotes and backtick

* Add exception for Package.swift in Swiftlint

- Add empty space for end of file.

* Add section Swift Package Manager
- Add dependency code with cauli release version

* Updated all cocoapods and fixed some SwiftLint warnings

* Updated Gems

* Updated Travis to use Xcode 11.3

* Reemoved tests for iOS 9

* #176 updated descriptions of inspector and mock floret

* #176 reuse subtitle cell in floret list

* #176 added example for overriding a floret description

* #176 removed unneeded constraint toggling

* #176 updated changelog

Co-authored-by: Cornelius Horstmann <cornelius@brototyp.de>
Co-authored-by: Cornelius Horstmann <csh@medicuja.com>
Co-authored-by: Akarsh Seggemu <sakarshkumar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brototyp-bot brototyp-bot brototyp-bot left review comments

@brototyp brototyp brototyp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Swift Package Manager to manage dependencies
3 participants
@akarsh @brototyp @brototyp-bot