Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle inf and nan in features #5

Closed
lacava opened this issue Sep 25, 2017 · 3 comments
Closed

handle inf and nan in features #5

lacava opened this issue Sep 25, 2017 · 3 comments
Assignees

Comments

@lacava
Copy link
Member

lacava commented Sep 25, 2017

handle inf and nan outputs in generated features

  • replace inf and nan in evaluated outputs with large values
@lacava
Copy link
Member Author

lacava commented Oct 9, 2017

inf: output max system size for stack type
nan: output 0

  • make safe function in base Node class
  • call safe on return values of evaluate function for division, exponent, and log nodes

@lacava lacava assigned tilakhere and lacava and unassigned tilakhere and lacava Oct 9, 2017
@lacava lacava mentioned this issue Oct 16, 2017
@lacava lacava closed this as completed Oct 16, 2017
@lacava
Copy link
Member Author

lacava commented Oct 23, 2017

reopening this issue because there are still issues with inf and nan features, especially when normalizing features. need to come up with a better strategy to address this.

@lacava lacava reopened this Oct 23, 2017
@lacava
Copy link
Member Author

lacava commented Oct 30, 2017

it seems like nans were coming from eigen's normalize function. this block manually checks for near-zero columns in X before normalizing.

@lacava lacava mentioned this issue Oct 31, 2017
@lacava lacava closed this as completed Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants