Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for wait_for pass hash with options like send_cmd does #6

Closed
vifreefly opened this issue Dec 3, 2018 · 1 comment
Closed

Comments

@vifreefly
Copy link

Currently it's not possible to pass options with wait_for command.
It will be nice to have this feature, because some of Chrome DevTools Protocol Events can accept options.

For example Page.frameStoppedLoading (can accept frameId option).

@vifreefly
Copy link
Author

I just found that it's possible to pass block to the wait_for method:

client.wait_for do |event_name, event_params|
  event_name == "Page.lifecycleEvent" && event_params["name"] == "load"
end

So the problem solved :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant