Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Netlify Button #76

Open
cben opened this issue Feb 20, 2015 · 11 comments · Fixed by #107
Open

Implement Netlify Button #76

cben opened this issue Feb 20, 2015 · 11 comments · Fixed by #107

Comments

@cben
Copy link
Owner

cben commented Feb 20, 2015

https://devcenter.heroku.com/articles/heroku-button
https://blog.openshift.com/instant-hosting-of-open-source-projects-with-github-style-ribbons/

Heroku is better for easy fork deployment due to:

  • unlimited 1 free dyno per app (vs RHcloud's 3 gears per user)
  • no size issues (so far), while on RHcloud I already had to pay a bit for quota doubling
  • fast deploy (<1 minute vs 7min)
@cben
Copy link
Owner Author

cben commented Apr 12, 2015

@cben
Copy link
Owner Author

cben commented May 27, 2015

Heroku Button won't work with submodules :-(

Heroku Button will not work with repos that have Git submodules. Heroku Button relies on the Build API and uses tarballs fetched from GitHub. GitHub does not include submodule contents when repo-content tarballs are generated.

@cben
Copy link
Owner Author

cben commented Aug 11, 2015

Tried the launch-shifter which IIUC is simply creates a workflow URL:

![LAUNCH ON OpenShift](https://launch-shifter.rhcloud.com/launch/LAUNCH ON.svg)

Clicking asks to login or create user. Created a new user (to check it works for a free user).
Filled app name & namespace (http://mathdown1–cbensf.rhcloud.com) but left branch empty.
=>

⚠ Unable to complete the requested operation. Show less

Shell command '/sbin/runuser -s /bin/sh 55c9b8900c1e66fd7f0000c0 -c "exec /usr/bin/runcon 'unconfined_u:system_r:openshift_t:s0:c1,c430' /bin/sh -c \"
set -xe;
shopt -s dotglob;
if [ "$(find objects -type f 2>/dev/null | wc -l)" -eq "0" ]; then
  exit 0;
fi
git archive --format=tar master | (cd /var/lib/openshift/55c9b8900c1e66fd7f0000c0/app-root/runtime/repo && tar --warning=no-timestamp -xf -);
\""' returned an error. rc=1
+ shopt -s dotglob
+ '[' 3 -eq 0 ']'
+ cd /var/lib/openshift/55c9b8900c1e66fd7f0000c0/app-root/runtime/repo
+ git archive --format=tar master
+ tar --warning=no-timestamp -xf -
fatal: Not a valid object name
tar: This does not look like a tar archive
tar: Exiting with failure status due to previous errors

@cben
Copy link
Owner Author

cben commented Aug 11, 2015

Trying branch = gh-pages...
=> perhaps working but SLOW. The original page was stuck on spinner, after 4-5 min said:

Application creation is taking longer than expected. Please wait a few minutes, then refresh this page.

The app after 4 minutes was still in "building" status on dashboard (and returned 503).
After 7 min, it's alive.

@cben
Copy link
Owner Author

cben commented Aug 11, 2015

"initial_git_branch: the name of your initial deployment branch. The default value is master."

![LAUNCH ON OpenShift](https://launch-shifter.rhcloud.com/launch/LAUNCH ON.svg)

@cben
Copy link
Owner Author

cben commented Aug 11, 2015

That pre-filled gh-pages successfully but deployment failed with some error (sorry, lost).
Retrying after deleting mathdown1 succeeded.
Then successfully launched mathdown3 (7.5min) in parallel to mathdown2, so it's not a resource limit (RHcloud should give 3 free gears).

@cben
Copy link
Owner Author

cben commented Aug 11, 2015

Closed as I can't implement Heroku button due to lack of submodule support.

@cben
Copy link
Owner Author

cben commented Sep 14, 2016

Reopening.
Openshift online is currently stuck between v2 which no longer accepts signups and v3 which is time-limited preview. The (hypotetical 🤣) hordes of contributors which want to fork Mathdown and instantly host it, have no trivial option. Heroku is an easy option with git push.
Anyway I want the full Heroku Quality of Life — button, review apps(!), possibly auto-deploy from github to staging (though deploy from travis CI might make more sense).

@cben cben reopened this Sep 14, 2016
@cben
Copy link
Owner Author

cben commented Sep 14, 2016

This is blocked on my use of submodules #115.
For Heroku should first investigate submodule buildpacks: #115 (comment)

@cben
Copy link
Owner Author

cben commented Dec 18, 2018

@cben
Copy link
Owner Author

cben commented Dec 17, 2022

As part of #172, I've moved from Heroku to Netlify. It spins up automatic preview apps for PRs.
But can still add a Netlify button https://www.netlify.com/blog/2016/11/29/introducing-the-deploy-to-netlify-button/ ?

In any case, should revise README.

@cben cben changed the title Implement Heroku Button and/or Openshift workflow URL Implement Netlify Button Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant