Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fine distributions to BMMs #160

Merged
merged 7 commits into from
Jun 28, 2024
Merged

Rename fine distributions to BMMs #160

merged 7 commits into from
Jun 28, 2024

Conversation

pawel-czyz
Copy link
Member

@pawel-czyz pawel-czyz commented May 29, 2024

@grfrederic This is an ongoing effort to replace fine distributions with BMMs (as described in #143). This requires considerable changes:

  • Update the imports in src/ (and make sure that the tests/ pass as they will also have to be updated.)
  • Update the names, such as FineSampler to BMMSampler.
  • Update the snakemake workflows (this is very important!)
  • Revise the documentation on fine distributions. Check if API is rendered properly.

Advice, comments, or changes pushed to this branch are welcome 🙂

@pawel-czyz pawel-czyz added 📖 type: documentation Improvements or additions to documentation 🔩 type: refactor Refactoring the code 👕 effort: L labels May 29, 2024
@pawel-czyz pawel-czyz linked an issue May 29, 2024 that may be closed by this pull request
5 tasks
�[3m�[1m�[31m                                Frankly, my dear, I don't give a damn.
�(B�[m�[1m�[31m                               – R. Butler, Gone With the Wind (1939) �(B�[m subpackage with BMM
@pawel-czyz pawel-czyz marked this pull request as ready for review June 28, 2024 19:17
@pawel-czyz pawel-czyz merged commit f4fa4f4 into main Jun 28, 2024
1 check passed
@pawel-czyz pawel-czyz deleted the pawel/update-docs branch June 28, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👕 effort: L 📖 type: documentation Improvements or additions to documentation 🔩 type: refactor Refactoring the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename fine distributions to BMMs
1 participant