Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing CANCER_TYPE_DETAILED in tcga studies? #17

Closed
pieterlukasse opened this issue Dec 2, 2016 · 6 comments
Closed

Missing CANCER_TYPE_DETAILED in tcga studies? #17

pieterlukasse opened this issue Dec 2, 2016 · 6 comments

Comments

@pieterlukasse
Copy link
Member

In cbioportal.org we now see the pancancer histogram view for BRCA study:

image

However, this does not seem to appear in the study loaded from datahub? Is the CANCER_TYPE_DETAILED field missing or empty in the datahub tcga studies?

@pieterlukasse
Copy link
Member Author

Notify: @n1zea144 @zheins : just something I noticed today, but I could be wrong about whether it is missing in datahub (maybe you recently added it). Please let me know.

@sandertan
Copy link
Contributor

When the study is downloaded from cbioportal.org, the datahub version is downloaded which misses CANCER_TYPE_DETAILED in sample/patient data. Would be cool to have it included!

@zheins
Copy link
Contributor

zheins commented Mar 29, 2017

@pieterlukasse @sandertan - We generate that via our internal importing pipelines. I'll add it to the files.

@zheins zheins mentioned this issue Mar 31, 2017
@sandertan
Copy link
Contributor

@zheins Could you check that the correct attribute is used to fill this column? This is from brca_tcga, it seems to miss the information from the public portal:
screen shot 2017-04-12 at 16 33 51

@pieterlukasse
Copy link
Member Author

@sandertan @zheins I checked this on the public portal again and what @sandertan observes there seems to be correct. The only difference is that "undefined" is called "NA" in study view. When you click "Customize histogram" you will see the other cancer types. They don't appear on the plot because the samples labelled with these cancer types just don't have mutations in TP53. I found another gene where they do have mutations, and it works as expected. See screenshot below:

image

@pieterlukasse
Copy link
Member Author

just tested it locally on newly downloaded dataset and it works as expected 👍

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants