Bug in AdagradTrainer

[gianlucabertani]

Hello,

there's a minor bug in AdagradTrainer at line 81. It currently reads:

    vol.SetGradient(i, 0.0); // zero out gradient so that we can begin accumulating anew

But in that point the correct index to use is j, not i:

    vol.SetGradient(j, 0.0); // zero out gradient so that we can begin accumulating anew

Forgive me if I don't submit a pull request, my fork has some more commits on top and branching just for this little fix would be a bit of a hassle.
Thanks again for your great work!

[cbovar]

Hi, Thank you! I have commited the fix on the main branch. Regards, Cedric

…

On Fri, Feb 17, 2017 at 6:35 PM, Gianluca Bertani ***@***.***> wrote: Hello, there's a minor bug in AdagradTrainer at line 81. It currently reads: vol.SetGradient(i, 0.0); // zero out gradient so that we can begin accumulating anew But in that point the correct index to use is *j*, not *i*: vol.SetGradient(j, 0.0); // zero out gradient so that we can begin accumulating anew Forgive me if I don't submit a pull request, my fork has some more commits on top and branching just for this little fix would be a bit of a hassle. Thanks again for your great work! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#29>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE3LkcBS_gKE7dkOXV2CgzItHAQ8Tzt8ks5rdXf_gaJpZM4MEHPe> .