Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

0.6.1: typing: conflict with the nodejs bindings #28

Closed
emmanueltouzery opened this issue Dec 10, 2016 · 5 comments
Closed

0.6.1: typing: conflict with the nodejs bindings #28

emmanueltouzery opened this issue Dec 10, 2016 · 5 comments

Comments

@emmanueltouzery
Copy link

emmanueltouzery commented Dec 10, 2016

when combining the tsmonad typing (.d.ts) with the "@types/node": "0.0.2", I get a conflict =>

node_modules/tsmonad/dist/tsmonad.d.ts(670,13): error TS2403: Subsequent variable declarations must have the same type.
Variable 'module' must be of type 'NodeModule', but here has type '{ exports: any; require(id: string): any; id: string; filename: string; loaded: boolean; parent: ...'.
@laurence-myers
Copy link

Yep, if I includes @types/node (6.0.50) I get this error. It's because tsmonad.ts is declaring a global var called "module", which conflicts with the normal Node definition.

@cbowdon
Copy link
Owner

cbowdon commented Mar 20, 2017

Thanks for raising this, and sorry for being an absent maintainer. I'll do my best to look into it when I can.

@cbowdon
Copy link
Owner

cbowdon commented Apr 17, 2017

A few changes have come in that should impact this. Can you please confirm if this is still an issue in 0.7.2?

@emmanueltouzery
Copy link
Author

sorry, not using the library anymore myself :(

@cbowdon
Copy link
Owner

cbowdon commented Mar 11, 2018

This hasn't been reported again, so assuming the issue was fixed by 0.7.2.

@cbowdon cbowdon closed this as completed Mar 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants