Fix Event Dialog Color Bug #81
Conversation
|
@cbrnr This fixed the bug that in XDF files color not changeable. One thing needs to be discussed here: The first event type gets categorized into "unknown group" simply because the event type set doesn't contain 0, while libxdf count event type from 0. I tentatively changed xdf_reader.cpp to event type + 1, but thought maybe it's better to directly modify it in libxdf to switch to 1 based instead of 0 based event types. But before doing so, I would like to consult with you here to see what you think. |
|
Thanks for fixing this bug. Regarding the event number, I already suggested in #61 that we should start with event number 1 because 0 is a special reserved type. I thought that you tried that and it didn't work? |
|
@cbrnr Hi Clemens, thank you for your comment. I think you are right: you mentioned it earlier, but I may have misunderstood it and done something wrong. However, this time I think I got it right. I amended the Fix Event Dialog Color Bug commit. If you got a moment, could you please review the code, and test it a bit? Thank you very much. I think now it fixes not only the color bug, but also the 'unknown group' problem. |
|
Very nice, now everything seems to work as it should 😄! The only thing I've noticed is that SigViewer still doesn't remember custom color settings (that is, after restarting all colors revert to their defaults). |
|
@cbrnr no problem, I will work on that :) |
Fix #80